Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @devfile/api types to devworkspace-client #19579

Closed
JPinkney opened this issue Apr 13, 2021 · 2 comments
Closed

Add @devfile/api types to devworkspace-client #19579

JPinkney opened this issue Apr 13, 2021 · 2 comments
Assignees
@sleshchenko
Labels
kind/enhancement A feature request - must adhere to the feature request template. sprint/current
Milestone
7.34

Comments

@JPinkney
Copy link
Contributor

Is your enhancement related to a problem? Please describe.

Now that devfile/api#384 is merged, we now have typescript types for the devfile api. We should integrate these into the devworkspace-client

Describe the solution you'd like

Add https://www.npmjs.com/package/@devfile/api to the devworkspace-client typescript library

Describe alternatives you've considered

Additional context
@JPinkney JPinkney added kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system. area/devworkspace-client labels Apr 13, 2021
@JPinkney JPinkney mentioned this issue Apr 13, 2021
Merged
@sleshchenko sleshchenko mentioned this issue Apr 15, 2021
Closed
29 tasks
@sleshchenko sleshchenko added sprint/next and removed sprint/next severity/P2 Has a minor but important impact to the usage or development of the system. labels Apr 15, 2021
@sleshchenko sleshchenko mentioned this issue Jun 11, 2021
Closed
@sleshchenko sleshchenko self-assigned this Jun 11, 2021
@sleshchenko
Copy link
Member

sleshchenko commented Jun 15, 2021 •
edited
Loading

There are two issues in devfile/api types currently:

@sleshchenko sleshchenko mentioned this issue Jul 9, 2021
Closed
16 tasks
@sleshchenko sleshchenko added this to the 7.34 milestone Jul 9, 2021
@sleshchenko
Copy link
Member

che-incubator/devworkspace-client#26 actually does what is needed but before merging it, it's needed to refactor Dashboard pretty significantly. Moving it to a separate issue #20191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleshchenko sleshchenko

Labels
kind/enhancement A feature request - must adhere to the feature request template. sprint/current
Projects
None yet
Milestone
7.34
Development

Successfully merging a pull request may close this issue.

WIP Use devfile API che-incubator/devworkspace-client
2 participants
@sleshchenko @JPinkney