Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor dashboard to use devfile/api types for devworkspaces #20191

Closed
sleshchenko opened this issue Jul 23, 2021 · 1 comment
Closed

Refactor dashboard to use devfile/api types for devworkspaces #20191

sleshchenko opened this issue Jul 23, 2021 · 1 comment
Assignees
@akurinnoy
Labels
area/dashboard kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. sprint/current
Milestone
7.37

Comments

@sleshchenko
Copy link
Member

sleshchenko commented Jul 23, 2021 •
edited
Loading

Is your task related to a problem? Please describe.

Refactor dashboard to use devfile/api types for devworkspaces.

So, instead of keeping in stores Devfile it should store DevWorkspace or DevWorkspaceSpecTemplate and convert it to devfile only when needed.

Also, we need some wrapper for devfile/api side, maybe on devworkspace client, that would simplify work with original types which has many optional.

Dashboard should use devworkspace client from che-incubator/devworkspace-client#26 (it's not merged because then it would break the current implementation.

There is a try to use devfile API but it's no successful and I'm not sure if even useful eclipse-che/che-dashboard#272
@sleshchenko sleshchenko added kind/task Internal things, technical debt, and to-do tasks to be performed. sprint/next area/dashboard labels Jul 23, 2021
@sleshchenko sleshchenko mentioned this issue Jul 23, 2021
Closed
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jul 23, 2021
@sleshchenko sleshchenko added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jul 26, 2021
@sleshchenko sleshchenko mentioned this issue Jul 28, 2021
Closed
7 tasks
@sleshchenko sleshchenko added this to the 7.35 milestone Jul 29, 2021
@nickboldt nickboldt modified the milestones: 7.35, 7.36 Aug 24, 2021
@sleshchenko sleshchenko modified the milestones: 7.36, 7.37 Sep 1, 2021
@akurinnoy akurinnoy mentioned this issue Sep 1, 2021
Merged
This was referenced Sep 7, 2021
Closed
Closed
@sleshchenko
Copy link
Member Author

solved with eclipse-che/che-dashboard#329

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akurinnoy akurinnoy

Labels
area/dashboard kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. sprint/current
Projects
None yet
Milestone
7.37
Development

No branches or pull requests
4 participants
@nickboldt @sleshchenko @akurinnoy @che-bot