Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node Debugging Experience #19952

Closed
tsmaeder opened this issue Jun 9, 2021 · 4 comments
Closed

Update Node Debugging Experience #19952

tsmaeder opened this issue Jun 9, 2021 · 4 comments
Assignees
Labels
area/languages Issues related to Language extensions or plugins integration. kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. sprint/current
Milestone

Comments

@tsmaeder
Copy link
Contributor

tsmaeder commented Jun 9, 2021

Is your enhancement related to a problem? Please describe.

The Debugging experience for Node seems to be much better in VS Code than what we have in Che right now. For example, when debugging the Theia back-end process, breakpoints in subprocesses (the plugin host process in particular) are hit, as well. I also feel the performance is better in VS Code.

Describe the solution you'd like

Let's investigate where we have gaps: in particular update the node-debug/node-debug2 extensions to a newer level and identify gaps in API or what we need to improve in the debugger implementation in Theia.

Describe alternatives you've considered

Additional context

@tsmaeder tsmaeder added the kind/enhancement A feature request - must adhere to the feature request template. label Jun 9, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jun 9, 2021
@tolusha tolusha added severity/P1 Has a major impact to usage or development of the system. area/languages Issues related to Language extensions or plugins integration. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jun 9, 2021
@ericwill ericwill mentioned this issue Jun 10, 2021
30 tasks
@tsmaeder
Copy link
Contributor Author

For starters, vs code now uses "jd-debug" for javascript debugging: https://github.com/microsoft/vscode-js-debug. To quote, "It has been the default JavaScript debugger in Visual Studio Code since 1.46".
We're still using node-debug and node-debug2 in Che.

@tsmaeder
Copy link
Contributor Author

Also, Theia is a bit behind on the Debugger API, in particular, it does not group debug sessions in a parent hierarchy.

@tsmaeder
Copy link
Contributor Author

I filed eclipse-theia/theia#9664, we're also quite behind on the DAP implementation: eclipse-theia/theia#8136

@ericwill ericwill mentioned this issue Jun 30, 2021
22 tasks
@svor svor removed the sprint/next label Jul 8, 2021
@svor svor mentioned this issue Jul 22, 2021
34 tasks
@svor svor removed the sprint/next label Jul 28, 2021
@svor svor mentioned this issue Aug 12, 2021
30 tasks
@svor svor removed the sprint/next label Aug 18, 2021
@svor svor added this to the 7.35 milestone Aug 18, 2021
@nickboldt nickboldt modified the milestones: 7.35, 7.36 Aug 24, 2021
@svor svor mentioned this issue Sep 7, 2021
26 tasks
@svor svor modified the milestones: 7.36, 7.37 Sep 8, 2021
@svor
Copy link
Contributor

svor commented Sep 23, 2021

jsdebug configuration was added for nodejs and nodejs+mongoDB devfiles v2
screenshot-nimbus-capture-2021 09 20-15_10_04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/languages Issues related to Language extensions or plugins integration. kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. sprint/current
Projects
None yet
Development

No branches or pull requests

6 participants