Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to latest DAP (1.41.0) #8136

Open
akosyakov opened this issue Jul 5, 2020 · 8 comments
Open

upgrade to latest DAP (1.41.0) #8136

akosyakov opened this issue Jul 5, 2020 · 8 comments
Labels
dap debug adapter protocol debug issues that related to debug functionality dependencies pull requests that update a dependency file help wanted issues meant to be picked up, require help

Comments

@akosyakov
Copy link
Member

akosyakov commented Jul 5, 2020 •
edited
Loading

I depends on #7100

TODO:
@akosyakov akosyakov added help wanted issues meant to be picked up, require help debug issues that related to debug functionality dependencies pull requests that update a dependency file dap debug adapter protocol labels Jul 5, 2020
@tsmaeder
Copy link
Contributor

Currently, we have "vscode-debugprotocol": "^1.32.0", but the latest version is now 1.48.x. Highlights since 1.32.0 include

  • Filters on exception breakpoints
  • Step granularity (line, instruction, statement)
  • Progress
  • Memory read & disassemble requests
  • data breakpoints

I would welcome any of those features.

@tsmaeder tsmaeder mentioned this issue Jun 29, 2021
Closed
@EvilBeaver
Copy link
Contributor

EvilBeaver commented May 5, 2022 •
edited
Loading

Exception breakpoint filters are very useful and it's sad they're not supported in Theia. Requesting an update to 1.48+

@colin-grant-work
Copy link
Contributor

We currently use version 1.51.0, but additional UI functionality based on the new features has yet to be implemented.

@colin-grant-work colin-grant-work mentioned this issue May 20, 2022
Merged
2 tasks
@EvilBeaver
Copy link
Contributor

@colin-grant-work

We currently use version 1.51.0, but additional UI functionality based on the new features has yet to be implemented.

Can you help me to find a place in UI's code where the new UI for exception breakpoints filters should be implemented?

@colin-grant-work
Copy link
Contributor

@EvilBeaver, in VSCode exception breakpoints are toggleable checkmarks that are present in the breakpoint view according to the kinds of exception breakpoints supported by the current debugger.

image

That would likely be the place to start in implementing a UI for exception breakpoints in Theia.

@EvilBeaver
Copy link
Contributor

@colin-grant-work yes, thanks :) I was asking where is this widget in the codebase? :) It's hard to find it for me, sorry. Can you tell me the modules where this widget is implemented/new UI should be implemented?

@colin-grant-work
Copy link
Contributor

Ah, apologies for the misunderstanding, @EvilBeaver.

Breakpoints and breakpoint metadata are managed here, and the rendering is done in this widget on the basis of this model's data.

@pisv pisv mentioned this issue Apr 21, 2023
Closed
@pisv
Copy link
Contributor

pisv commented Apr 21, 2023

Extracted feature request for conditional exception breakpoints to its own issue #12444.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dap debug adapter protocol debug issues that related to debug functionality dependencies pull requests that update a dependency file help wanted issues meant to be picked up, require help
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@EvilBeaver @akosyakov @pisv @tsmaeder @colin-grant-work