Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade che-operator to controller-runtime 0.9.5 #20300

Closed
metlos opened this issue Aug 16, 2021 · 2 comments
Closed

Upgrade che-operator to controller-runtime 0.9.5 #20300

metlos opened this issue Aug 16, 2021 · 2 comments
Assignees
@AndrienkoAleksandr
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Milestone
7.38

Comments

@metlos
Copy link
Contributor

metlos commented Aug 16, 2021

Is your enhancement related to a problem? Please describe

Currently, che-operator depends on sigs.k8s.io/controller-runtime v0.6.3. Because DWO is in the process of migrating to controller runtime 0.9.5 (devfile/devworkspace-operator#540) and DWO is a dependency of che-operator, we should also consider upgrading from the old version of the controller runtime currently in use.

Describe the solution you'd like

Use the same version of sigs.k8s.io/controller-runtime in both che-operator and DWO.

Describe alternatives you've considered

Keep an increasingly complex list of version replacements and pray everything somehow still works together.

Additional context

No response
@metlos metlos added kind/enhancement A feature request - must adhere to the feature request template. area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator labels Aug 16, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 16, 2021
@metlos metlos mentioned this issue Aug 16, 2021
Closed
@ibuziuk ibuziuk added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Aug 16, 2021
@tolusha tolusha mentioned this issue Sep 3, 2021
Closed
29 tasks
@AndrienkoAleksandr AndrienkoAleksandr self-assigned this Sep 6, 2021
@tolusha tolusha added this to the 7.37 milestone Sep 8, 2021
This was referenced Sep 13, 2021
Merged
Merged
@tolusha tolusha mentioned this issue Sep 27, 2021
Closed
27 tasks
@tolusha tolusha modified the milestones: 7.37, 7.38 Sep 28, 2021
@tolusha tolusha closed this as completed Oct 1, 2021
@l0rd
Copy link
Contributor

l0rd commented Oct 6, 2021

Is that compatible with OCP 3.11?

@tolusha
Copy link
Contributor

tolusha commented Oct 6, 2021

We run our PR checks on minishift, so I assume it is compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrienkoAleksandr AndrienkoAleksandr

Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.38
Development

No branches or pull requests
6 participants
@metlos @l0rd @ibuziuk @tolusha @AndrienkoAleksandr @che-bot