Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update controller runtime #1064

Merged
merged 39 commits into from
Oct 1, 2021
Merged

Conversation

AndrienkoAleksandr
Copy link
Contributor

@AndrienkoAleksandr AndrienkoAleksandr commented Sep 13, 2021

Controller runtime update to version v0.9.5
go-client update to version v0.21.3
Udaptated tests to the new controller runtime and go-client.
Commented image puller temporary.
Commented zap logger and some other deps.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Sep 13, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #1064 (0ab672d) into main (5397000) will increase coverage by 0.08%.
The diff coverage is 63.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1064      +/-   ##
==========================================
+ Coverage   54.17%   54.26%   +0.08%     
==========================================
  Files          67       67              
  Lines        8422     8388      -34     
==========================================
- Hits         4563     4552      -11     
+ Misses       3379     3364      -15     
+ Partials      480      472       -8     
Impacted Files Coverage Δ
controllers/devworkspace/solver/solver.go 42.85% <0.00%> (ø)
pkg/deploy/kubernetes_image_puller.go 4.83% <0.00%> (-0.03%) ⬇️
pkg/util/k8s_helpers.go 10.00% <0.00%> (ø)
controllers/che/checluster_controller.go 20.47% <7.69%> (+0.13%) ⬆️
controllers/devworkspace/sync/sync.go 53.75% <66.66%> (+3.21%) ⬆️
pkg/deploy/dev-workspace/dev_workspace.go 61.21% <66.66%> (ø)
controllers/usernamespace/controller.go 67.22% <80.00%> (-0.14%) ⬇️
pkg/deploy/sync.go 67.45% <88.57%> (+3.81%) ⬆️
controllers/devworkspace/controller.go 50.00% <100.00%> (-0.23%) ⬇️
controllers/usernamespace/namespacecache.go 72.88% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5397000...0ab672d. Read the comment docs.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr
Copy link
Contributor Author

AndrienkoAleksandr commented Sep 14, 2021

In general pull request is ready for review. I will work on dependencies list in the go.mod, go.sum. Code part I think will be unchangeable.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr AndrienkoAleksandr changed the title Update controller runtime feat: Update controller runtime Sep 16, 2021
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr
Copy link
Contributor Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Sep 22, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, metlos, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Sep 30, 2021
@openshift-ci
Copy link

openshift-ci bot commented Sep 30, 2021

New changes are detected. LGTM label has been removed.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr
Copy link
Contributor Author

/retest

@tolusha tolusha closed this Sep 30, 2021
@tolusha tolusha reopened this Sep 30, 2021
@AndrienkoAleksandr AndrienkoAleksandr merged commit b8cc02b into main Oct 1, 2021
@AndrienkoAleksandr AndrienkoAleksandr deleted the update-controller-runtime branch October 1, 2021 11:54
@che-bot che-bot added this to the 7.38 milestone Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants