-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update controller runtime #1064
Conversation
Controller runtime update to version v0.9.5 go-client update to version v0.21.3 Udaptated tests to the new controller runtime and go-client. Commented image puller temporary. Commented zap logger and some other deps. Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Skipping CI for Draft Pull Request. |
Codecov Report
@@ Coverage Diff @@
## main #1064 +/- ##
==========================================
+ Coverage 54.17% 54.26% +0.08%
==========================================
Files 67 67
Lines 8422 8388 -34
==========================================
- Hits 4563 4552 -11
+ Misses 3379 3364 -15
+ Partials 480 472 -8
Continue to review full report at Codecov.
|
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
In general pull request is ready for review. I will work on dependencies list in the go.mod, go.sum. Code part I think will be unchangeable. |
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
…e-controller-runtime
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
/retest |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AndrienkoAleksandr, metlos, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…e-controller-runtime
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
New changes are detected. LGTM label has been removed. |
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
/retest |
What does this PR do?
Update controller runtime to v0.9.5.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#20300
Depends on:
eclipse-che/che#20425 with pull request: che-incubator/kubernetes-image-puller-operator#69
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.