Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Che-server isn't reconfigured after adding OAuth Config secret #20841

Closed
skabashnyuk opened this issue Nov 30, 2021 · 1 comment
Closed

Che-server isn't reconfigured after adding OAuth Config secret #20841

skabashnyuk opened this issue Nov 30, 2021 · 1 comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@skabashnyuk
Copy link
Contributor

skabashnyuk commented Nov 30, 2021

Describe the bug

After adding OAuth secret to the eclipse-che namespace che-operator isn't reconfigure che-server with OAuth settings.

Che version

7.39@latest

Steps to reproduce

  1. deploy che chectl server:deploy --platform=openshift --installer=operator --workspace-engine=dev-workspace and add secret
kubectl apply -f - <<EOF
kind: Secret
apiVersion: v1
metadata:
  name: github-oauth-config
  namespace: eclipse-che
  labels:
    app.kubernetes.io/part-of: che.eclipse.org
    app.kubernetes.io/component: oauth-scm-configuration
  annotations:
    che.eclipse.org/oauth-scm-server: github
type: Opaque
data:
  id: ?? 
  secret: ??
EOF
  1. che-server didn't reconfigured.

Expected behavior

At step 2 che-operator should mount secret as a file and provide environment variables that point to this file.

Runtime

OpenShift

Screenshots

No response

Installation method

chectl/next

Environment

Linux

Eclipse Che Logs

n/a

Additional context

https://github.com/eclipse-che/che-operator/blob/main/pkg/deploy/server/server_deployment.go#L492-L500
CHE_OAUTH_GITHUB_CLIENTID__FILEPATH: /che-conf/oauth/github/id
CHE_OAUTH_GITHUB_CLIENTSECRET__FILEPATH: /che-conf/oauth/github/secret

@skabashnyuk skabashnyuk added kind/bug Outline of a bug - must adhere to the bug report template. area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator labels Nov 30, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Nov 30, 2021
@tolusha tolusha added sprint/next team/deploy severity/P1 Has a major impact to usage or development of the system. labels Nov 30, 2021
@tolusha tolusha mentioned this issue Nov 30, 2021
28 tasks
@tolusha
Copy link
Contributor

tolusha commented Nov 30, 2021

caused by eclipse-che/che-operator#1166

@svor svor removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Nov 30, 2021
@tolusha tolusha added this to the 7.40 milestone Nov 30, 2021
@tolusha tolusha closed this as completed Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

4 participants