fix: don't require app.kubernetes.io/instance:che label on k8s object to trigger a reconcile

[tolusha]

Signed-off-by: Anatolii Bazko abazko@redhat.com

What does this PR do?

Fix for #1166 not to require app.kubernetes.io/instance:che label for k8s objects to trigger a reconcile

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#20841

How to test this PR?

1. Deploy Eclipse Che

chectl server:deploy \
     --installer operator \
     --platform minikube \
     --che-operator-image abazko/operator:20841

2. Create config map

kubectl create configmap ca-certs -n eclipse-che
kubectl label configmap/ca-certs  app.kubernetes.io/part-of=che.eclipse.org app.kubernetes.io/component=ca-bundle -n eclipse-che 

3. Check that configamp is included into ca-certs-merged

kubectl get configmap ca-certs-merged -n eclipse-che -o jsonpath="{.metadata.annotations}"

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• Custom resource definition file is up to date
• OLM bundles are up to date
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

[mmorhun]

I think we should add part-of label requirement, shouldn't we?

[mmorhun]

Or even replace instance requirement...

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmorhun, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@tolusha: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v7-single-host-nightly-deployment	621f04d	link	true	/test v7-single-host-nightly-deployment
ci/prow/v7-devworkspace-happy-path	621f04d	link	true	/test v7-devworkspace-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.