Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to jwtproxy and plugin-broker GitHub repositories #21275

Closed
3 tasks done
l0rd opened this issue Mar 16, 2022 · 5 comments
Closed
3 tasks done

Remove references to jwtproxy and plugin-broker GitHub repositories #21275

l0rd opened this issue Mar 16, 2022 · 5 comments
Labels
area/ci CI build and releases, PR testing, & whitelabel/productization issues kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P1 Has a major impact to usage or development of the system.

Comments

@l0rd
Copy link
Contributor

l0rd commented Mar 16, 2022 •
edited
Loading

Is your task related to a problem? Please describe

Although JWT Proxy and the plugin broker are not used anymore since Che 7.42 (i.e. the switch to DevWorkspace Operator) they cannot be archived as they are still referenced in Che Operator CSV and tagged at every release by the build process.

Describe the solution you'd like

Describe alternatives you've considered

No response

Additional context

No response
@l0rd l0rd added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Mar 16, 2022
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Mar 16, 2022
@nickboldt nickboldt added area/ci CI build and releases, PR testing, & whitelabel/productization issues team/deploy severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Mar 17, 2022
@nickboldt
Copy link
Contributor

Downstream https://issues.redhat.com/browse/CRW-2830

@che-bot
Copy link
Contributor

che-bot commented Sep 13, 2022

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 13, 2022
@l0rd
Copy link
Contributor Author

l0rd commented Sep 15, 2022

/remove-lifecycle stale

@che-bot che-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 15, 2022
@l0rd
Copy link
Contributor Author

l0rd commented Sep 15, 2022

@nickboldt @tolusha We are not referencing and releasing those 2 components anymore right? If you confirm I will create an eclipse.org ticket to archive the github repositories.

@che-bot
Copy link
Contributor

che-bot commented Jun 7, 2023

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 7, 2023
@che-bot che-bot closed this as completed Jun 14, 2023
amisevsk added a commit to amisevsk/che-code that referenced this issue Nov 13, 2023
@amisevsk
Remove JWT endpoint handling in che-port extension
a4cd9b4 
The JWT proxy was removed as of Che 7.42 and is no longer used.

See Che issue eclipse-che/che#21275 for details.

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
@amisevsk amisevsk assigned amisevsk and unassigned amisevsk Nov 13, 2023
amisevsk added a commit to amisevsk/che-code that referenced this issue Nov 14, 2023
@amisevsk
[ports-plugin] Remove JWT endpoint handling in che-port extension
4be3f12 
The JWT proxy was removed as of Che 7.42 and is no longer used.

See Che issue eclipse-che/che#21275 for details.

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
amisevsk added a commit to che-incubator/che-code that referenced this issue Nov 20, 2023
@amisevsk
[ports-plugin] don't prompt user to redirect endpoints with `exposure…
44799de 
…: none` (#301)

* [ports-plugin] Remove JWT endpoint handling in che-port extension

The JWT proxy was removed as of Che 7.42 and is no longer used.

See Che issue eclipse-che/che#21275 for details.

* [ports-plugin] Don't prompt to expose endpoints with exposure: none in ports-plugin

If an endpoint exists in the devfile and has exposure: none, we
shouldn't prompt the user to expose that endpoint if a process starts
listening on localhost.

* [ports-plugin] Update prompt when process is listening to localhost

If a process starts that is listening to localhost (and is thus
inaccessible from outside the pod), we show a prompt to the user to add
it to Code's redirect routes. However, if the process is listening on a
port that matches a public endpoint in the devfile, we should prompt
differently, noting the potential error, since the user intends to use
the endpoint route instead of a redirect route.

---------

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ci CI build and releases, PR testing, & whitelabel/productization issues kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nickboldt @l0rd @amisevsk @che-bot