Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling the extended Shell integration breaks the auto-opened terminal in Che-Code #21616

Closed
Tracked by #21705
azatsarynnyy opened this issue Aug 5, 2022 · 1 comment
Assignees
Labels
area/editor/vscode Issues related to the Code OSS editor of Che kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone

Comments

@azatsarynnyy
Copy link
Member

azatsarynnyy commented Aug 5, 2022

Is your task related to a problem? Please describe

There's a Shell integration feature has been recently introduced in VS Code.
https://code.visualstudio.com/updates/v1_70#_shell-integration-enabled-by-default
When it's enabled, it breaks the auto-opened terminal in Che-Code. Input is not available. See #21537 for more details.

Describe the solution you'd like

Need to investigate why it breaks the terminal at Che-Code start.

Describe alternatives you've considered

Currently, we've disabled the Shell integration by default.
che-incubator/che-code#90

In the future, I'd like to rework the machine-exec terminal support with the VS Code Terminal API. I think it would allow us to use the full-featured VS Code terminal in 90% of the cases when the terminal is opened into the editor container. And use the machine-exec-aware terminal, contributed by an extension, for non-editor containers only.

Additional context

No response

@azatsarynnyy azatsarynnyy added kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system. team/editors area/editor/vscode Issues related to the Code OSS editor of Che labels Aug 5, 2022
@azatsarynnyy azatsarynnyy self-assigned this Sep 20, 2022
@azatsarynnyy azatsarynnyy added this to the 7.55 milestone Sep 20, 2022
@azatsarynnyy
Copy link
Member Author

Fixed by the PR che-incubator/che-code#124

Now, Shell integration is enabled in Che-Code by default:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/vscode Issues related to the Code OSS editor of Che kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

1 participant