Disable shell integration #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable the extended shell integration feature as it breaks the machine-exec terminal.
azatsarynnyy
requested review from
RomanNikitenko,
vzhukovs and
benoitf
as code owners
benoitf
reviewed
Aug 5, 2022
code/src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts
Outdated
Show resolved
Hide resolved
benoitf
approved these changes
Aug 5, 2022
…ation.ts Co-authored-by: Florent BENOIT <fbenoit@redhat.com>
|
Pull Request images published ✨ |
|
Pull Request images published ✨ |
|
Pull Request images published ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable the extended shell integration feature as it breaks the machine-exec terminal.
fixes eclipse-che/che#21537
How to test
Once the github-actions bot publishes the quay.io/che-incubator-pull-requests/che-code:pr-90-amd64 image (it should comment on the PR), run #https://github.com/azatsarynnyy/java-spring-petclinic/tree/devfilev2.
Check that the terminal, opened on Che-Code start, works as expected.