Add global.ingressClass into values.yaml.
#11820
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monaka
requested review from
garagatyi,
l0rd,
riuvshin and
sleshchenko
as code owners
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
As it was discussed on #10751, Ingress on AKS have an issue related on |
benoitf
added
status/code-review
sleshchenko
reviewed
Nov 5, 2018
| @@ -32,6 +32,8 @@ global: | |||
| # This value can be passed if custom Oidc provider is used, and there is no need to deploy keycloak in multiuser mode | |||
| # default (if empty) is true | |||
| #cheDedicatedKeycloak: false | |||
| ingressClass: "ingress" | |||
| #ingressClass: "addon-http-application-routing" ## This may fix the issue around bootstraping your stacks on Azure AKS. | |||
There was a problem hiding this comment.
What is right value for .global.ingressAnnotationsPrefix if .global.ingressClass is set to addon-http-application-routing? Will default value nginx. will work fine?
garagatyi
reviewed
Nov 5, 2018
| @@ -32,6 +32,8 @@ global: | |||
| # This value can be passed if custom Oidc provider is used, and there is no need to deploy keycloak in multiuser mode | |||
| # default (if empty) is true | |||
| #cheDedicatedKeycloak: false | |||
| ingressClass: "ingress" | |||
There was a problem hiding this comment.
The previously hardcoded value was "nginx". Now it would be pointing to this value which is "ingress". Shouldn't it be "nginx"?
| {{- else }} | ||
| CHE_INFRA_KUBERNETES_INGRESS_ANNOTATIONS__JSON: '{"kubernetes.io/ingress.class": "nginx", "{{ .Values.global.ingressAnnotationsPrefix }}ingress.kubernetes.io/rewrite-target": "/","{{ .Values.global.ingressAnnotationsPrefix }}ingress.kubernetes.io/ssl-redirect": "false","{{ .Values.global.ingressAnnotationsPrefix }}ingress.kubernetes.io/proxy-connect-timeout": "3600","{{ .Values.global.ingressAnnotationsPrefix }}ingress.kubernetes.io/proxy-read-timeout": "3600"}' | ||
| CHE_INFRA_KUBERNETES_INGRESS_ANNOTATIONS__JSON: '{"kubernetes.io/ingress.class": {{ .Values.global.ingressClass }}, "{{ .Values.global.ingressAnnotationsPrefix }}ingress.kubernetes.io/rewrite-target": "/","{{ .Values.global.ingressAnnotationsPrefix }}ingress.kubernetes.io/ssl-redirect": "false","{{ .Values.global.ingressAnnotationsPrefix }}ingress.kubernetes.io/proxy-connect-timeout": "3600","{{ .Values.global.ingressAnnotationsPrefix }}ingress.kubernetes.io/proxy-read-timeout": "3600"}' |
There was a problem hiding this comment.
Having {{ .Values.global.ingressClass }} in double quotes make it more aligned with other values.
| @@ -66,9 +66,9 @@ data: | |||
| JAVA_OPTS: "-XX:MaxRAMFraction=2 -XX:+UseParallelGC -XX:MinHeapFreeRatio=10 -XX:MaxHeapFreeRatio=20 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90 -XX:+UnlockExperimentalVMOptions -XX:+UseCGroupMemoryLimitForHeap -Dsun.zip.disableMemoryMapping=true -Xms20m " | |||
| CHE_WORKSPACE_AUTO_START: "false" | |||
| {{- if .Values.global.tls.enabled }} | |||
| CHE_INFRA_KUBERNETES_INGRESS_ANNOTATIONS__JSON: '{"kubernetes.io/ingress.class": "nginx", "kubernetes.io/tls-acme": "true", "{{ .Values.global.ingressAnnotationsPrefix }}ingress.kubernetes.io/rewrite-target": "/","{{ .Values.global.ingressAnnotationsPrefix }}ingress.kubernetes.io/ssl-redirect": "true","{{ .Values.global.ingressAnnotationsPrefix }}ingress.kubernetes.io/proxy-connect-timeout": "3600","{{ .Values.global.ingressAnnotationsPrefix }}ingress.kubernetes.io/proxy-read-timeout": "3600"}' | |||
| CHE_INFRA_KUBERNETES_INGRESS_ANNOTATIONS__JSON: '{"kubernetes.io/ingress.class": {{ .Values.global.ingressClass }}, "kubernetes.io/tls-acme": "true", "{{ .Values.global.ingressAnnotationsPrefix }}ingress.kubernetes.io/rewrite-target": "/","{{ .Values.global.ingressAnnotationsPrefix }}ingress.kubernetes.io/ssl-redirect": "true","{{ .Values.global.ingressAnnotationsPrefix }}ingress.kubernetes.io/proxy-connect-timeout": "3600","{{ .Values.global.ingressAnnotationsPrefix }}ingress.kubernetes.io/proxy-read-timeout": "3600"}' | |||
There was a problem hiding this comment.
Having {{ .Values.global.ingressClass }} in double quotes make it more aligned with other values.
Signed-off-by: Masaki Muranaka <monaka@monami-ya.com>
|
@sleshchenko @garagatyi Today, I changed my opinion. I close this now and will send another pull request (for more details: #12645). Thank you for your review and comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adding new value
glbal.ingressClassfor customizingingress.classannotations.What issues does this PR fix or reference?
This will fix indirectly #10751 #10767 #10099