Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made PVC Strategies wait until PVCs are bound during preparing #11920

Merged
merged 4 commits into from
Nov 15, 2018
Merged

Made PVC Strategies wait until PVCs are bound during preparing #11920

merged 4 commits into from
Nov 15, 2018

Conversation

sleshchenko
Copy link
Member

What does this PR do?

The main purpose of this PR is making PVC Strategies wait until PVCs are bound during preparing. It prevents an unrecoverable event happening when PVCs binding is slow.

Also, this PR contains the following minor changes:

  • Fix dependencies scope.
    • Remove duplicated dependency declaration for che-core-api-project to
      avoid warning message during maven build
    • Change scope of che-core-api-languageserver dependency to test to fix
      issue while building Che without compiling of tests
  • Add info message about applied logger config

What issues does this PR fix or reference?

#11848

Release Notes

N/A

Docs PR

N/A

@sleshchenko sleshchenko added kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Nov 13, 2018
@sleshchenko sleshchenko self-assigned this Nov 13, 2018
@sleshchenko
Copy link
Member Author

@eivantsov I tested it locally and looks like it works but now my minikube is quite fast and it takes only 1 second to bound pvc. Could you test my built Che Server sleshchenko/che-server:pvc on your Kubernetes?

amisevsk
amisevsk approved these changes Nov 13, 2018
View reviewed changes
Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- great fix.

@skabashnyuk skabashnyuk mentioned this pull request Nov 13, 2018
Closed
7 tasks
@metlos metlos mentioned this pull request Nov 13, 2018
Merged
7 tasks
garagatyi
garagatyi approved these changes Nov 14, 2018
View reviewed changes
Copy link

@garagatyi garagatyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sleshchenko
Copy link
Member Author

ci-test

@sleshchenko sleshchenko requested a review from a user November 14, 2018 14:46
@riuvshin
Copy link
Contributor

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11920
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@sleshchenko
Copy link
Member Author

ci-test

@ghost
Copy link

ghost commented Nov 15, 2018

Tested against a cluster with gluster. Works fine.

@riuvshin
Copy link
Contributor

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11920
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Nov 15, 2018 •
edited
Loading

Latest ci-test build failed because it took more that 5 hours.
You can find server logs here.

@sleshchenko
Fix dependencies scope
ef54e6c 
Remove duplicated dependency declaration for che-core-api-project to
avoid warning message during maven build

Change scope of che-core-api-languageserver dependency to `test` to fix
issue while building Che without compiling of tests
@sleshchenko
Add info message about aplied logger config
18e4088
@sleshchenko
Make PVC Strategies wait until PVCs are bound during preparing
a4f8410
@sleshchenko
Update comment about helm chart parameter
8514aae
@sleshchenko
Copy link
Member Author

ci-test

@sleshchenko sleshchenko merged commit 438aa3a into eclipse-che:master Nov 15, 2018
@sleshchenko sleshchenko deleted the pvcBound branch November 15, 2018 13:57
This was referenced Nov 15, 2018
Closed
Closed
@riuvshin
Copy link
Contributor

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11920
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@sleshchenko sleshchenko mentioned this pull request Nov 16, 2018
Closed
@ghost ghost mentioned this pull request Nov 16, 2018
Closed
@benoitf benoitf added this to the 6.15.0 milestone Nov 16, 2018
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Nov 16, 2018
@yarivlifchuk yarivlifchuk mentioned this pull request Jan 28, 2019
Closed
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garagatyi garagatyi garagatyi approved these changes

@skabashnyuk skabashnyuk skabashnyuk approved these changes

@amisevsk amisevsk amisevsk approved these changes

@mshaposhnik mshaposhnik Awaiting requested review from mshaposhnik

@tolusha tolusha Awaiting requested review from tolusha

@l0rd l0rd Awaiting requested review from l0rd

@riuvshin riuvshin Awaiting requested review from riuvshin

Assignees

@sleshchenko sleshchenko

Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Milestone
6.15.0
Development

Successfully merging this pull request may close these issues.
7 participants
@sleshchenko @riuvshin @dmytro-ndp @skabashnyuk @garagatyi @amisevsk @benoitf