Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selenium: Add/Delete 'try-catch' according to known issues #12473

Merged
merged 1 commit into from
Jan 19, 2019
Merged

Selenium: Add/Delete 'try-catch' according to known issues #12473

merged 1 commit into from
Jan 19, 2019

Conversation

artaleks9
Copy link
Contributor

What does this PR do?

  • Add the try-catch to the selenium test JsonFileEditingTest according to the known issue
  • Delete try-catch from the selenium test RunPlainJavaProjectTest according to fix bug and merged PR Detect Simple Java Projects on Import #12041

What issues does this PR fix or reference?

#12472
#11516

@artaleks9 artaleks9 added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. team/che-qe labels Jan 19, 2019
@artaleks9
Copy link
Contributor Author

ci-test

@che-bot
Copy link
Contributor

che-bot commented Jan 19, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:12473
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@artaleks9 artaleks9 merged commit eaf20df into master Jan 19, 2019
@artaleks9 artaleks9 deleted the add-try-catch branch January 19, 2019 20:29
@che-bot che-bot added this to the 6.18.0 milestone Jan 19, 2019
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jan 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ndp dmytro-ndp dmytro-ndp approved these changes

@musienko-maxim musienko-maxim Awaiting requested review from musienko-maxim

@Ohrimenko1988 Ohrimenko1988 Awaiting requested review from Ohrimenko1988

Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
6.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@artaleks9 @che-bot @dmytro-ndp