Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHE-12376: Fix IDE link navigation #12561

Merged
merged 10 commits into from
Feb 6, 2019
Merged

CHE-12376: Fix IDE link navigation #12561

merged 10 commits into from
Feb 6, 2019

Conversation

vparfonov
Copy link
Contributor

@vparfonov vparfonov commented Jan 30, 2019 •
edited
Loading

What does this PR do?

Fix link navigation, now should work correct for GWT IDE and for Theia IDE

What issues does this PR fix or reference?

#12376

Release Notes

Docs PR

@vparfonov
Set URL for IDE in workspace config which will navigate to the Worksp…
30efb52 
…ace Loader. It will help solve problem with serving different kind of IDE

Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
@vparfonov
Fix test
2aa2975 
Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
@vparfonov
Copy link
Contributor Author

ci-test

@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. labels Jan 30, 2019
@che-bot
Copy link
Contributor

che-bot commented Jan 30, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:12561
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

slemeur
slemeur suggested changes Jan 31, 2019
View reviewed changes
Copy link
Contributor

@slemeur slemeur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No - we don't want to change the URL to access a workspace.

@vparfonov
Copy link
Contributor Author

ok, will try to found other solution

@vparfonov
Rework IDE loader. Remove odd files
59910d2 
Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
@todo
Copy link

todo bot commented Feb 1, 2019

move to constant

https://github.com/eclipse/che/blob/59910d2cad86682b7788171fe6fb9672d1876b68/ide/che-ide-gwt-app/src/main/resources/org/eclipse/che/ide/public/bundle.js#L863-L868

This comment was generated by todo based on a @todo comment in 59910d2 in #12561. cc @eclipse.

@vparfonov
Copy link
Contributor Author

ci-test

@che-bot
Copy link
Contributor

che-bot commented Feb 1, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:12561
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@vparfonov
Fix tests and license header
7f9e41d 
Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
@vparfonov
Copy link
Contributor Author

ci-test

@che-bot
Copy link
Contributor

che-bot commented Feb 1, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:12561
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@vparfonov
Restore loder.* files from master
b6c9bc0 
Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
@vparfonov
Copy link
Contributor Author

ci-test

@che-bot
Copy link
Contributor

che-bot commented Feb 4, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:12561
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@vparfonov
Copy link
Contributor Author

ci-test

@che-bot
Copy link
Contributor

che-bot commented Feb 4, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:12561
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@vparfonov
Copy link
Contributor Author

ci-test

@che-bot
Copy link
Contributor

che-bot commented Feb 4, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:12561
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@vparfonov
Temporary rename loder.html
4e82934 
Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
@vparfonov
Copy link
Contributor Author

ci-test

@che-bot
Copy link
Contributor

che-bot commented Feb 5, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:12561
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@vparfonov
Restore loader.html. Try to understand why Selenium test fail
8c31527 
Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
@vparfonov
Restore loader.html. Try to understand why Selenium test fail
641caf5 
Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
@vparfonov
Merge branch 'master' into che#12376
47fafb9
@vparfonov
Restore indext.ts from master
698bb46 
Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
@vparfonov
Copy link
Contributor Author

ci-test

@che-bot
Copy link
Contributor

che-bot commented Feb 5, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:12561
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@artaleks9
Copy link
Contributor

Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/1517/) doesn't show any regression against this Pull Request.

@vparfonov vparfonov removed the request for review from garagatyi February 6, 2019 10:50
@vparfonov vparfonov merged commit dda1362 into master Feb 6, 2019
@vparfonov vparfonov deleted the che#12376 branch February 6, 2019 10:53
@todo todo bot mentioned this pull request Feb 6, 2019
Closed
@vparfonov vparfonov added this to the 6.19.0 milestone Feb 6, 2019
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Feb 6, 2019
@ibuziuk
Copy link
Member

ibuziuk commented Feb 6, 2019

@riuvshin @vparfonov any chance we could include this to 6.18.0 or it is too late ?

@ibuziuk ibuziuk mentioned this pull request Feb 11, 2019
Closed
riuvshin pushed a commit that referenced this pull request Feb 12, 2019
@vparfonov
CHE-12376: Fix IDE link navigation (#12561)
716de97 
* Embed script to the IDE.html page which can detect correct location for IDE App
Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slemeur slemeur slemeur approved these changes

@skabashnyuk skabashnyuk Awaiting requested review from skabashnyuk

@ibuziuk ibuziuk Awaiting requested review from ibuziuk

Assignees
No one assigned
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Milestone
6.19.0
Development

Successfully merging this pull request may close these issues.
5 participants
@vparfonov @che-bot @artaleks9 @ibuziuk @slemeur