Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Django sample #13135

Merged
merged 1 commit into from
Apr 16, 2019
Merged

Add Django sample #13135

merged 1 commit into from
Apr 16, 2019

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Apr 12, 2019

Signed-off-by: Anatoliy Bazko abazko@redhat.com

What does this PR do?

Adds django sample [1] to the list of available sample for Che 7 Python stack.

What issues does this PR fix or reference?

#12945

[1] https://github.com/gothinkster/django-realworld-example-app

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
@tolusha tolusha added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Apr 12, 2019
@tolusha tolusha requested review from l0rd and sleshchenko April 12, 2019 14:00
@tolusha tolusha self-assigned this Apr 12, 2019
@tolusha
Copy link
Contributor Author

tolusha commented Apr 12, 2019

/cc @slemeur
Know issue: django admin page can't be shown in preview widget, probably due to iframe.

@tolusha
Copy link
Contributor Author

tolusha commented Apr 12, 2019

ci-test

@tolusha
Copy link
Contributor Author

tolusha commented Apr 12, 2019

It is impossible to test provided commands due to eclipse-che/che-theia#155

@che-bot
Copy link
Contributor

che-bot commented Apr 12, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13135
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

"type": "dockerimage"
},
"machines": {
"python": {
"servers": {
"django": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need a server? Isn't the port plugin exposing it automatically?

Copy link
Contributor Author

@tolusha tolusha Apr 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the port plugin exposing it automatically?

Yes, it is. But after a little application becomes unavailable.
So, that's why I added sever to the list

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you saying that the application is unstable when using the port plugin but works just fine if you define a server?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly

Logs from theia-ide container (minishift):

root ERROR Uncaught Exception:  Error [ERR_IPC_CHANNEL_CLOSED]: Channel closed
--
  | root ERROR Error [ERR_IPC_CHANNEL_CLOSED]: Channel closed
  | at ChildProcess.target.send (internal/child_process.js:636:16)
  | at HostedPluginProcess.onMessage (/home/theia/node_modules/@theia/plugin-ext/lib/hosted/node/hosted-plugin-process.js:105:31)
  | at ServerPluginProxyRunner.onMessage (/home/theia/node_modules/@eclipse-che/theia-remote/lib/node/server-plugin-proxy-runner.js:49:32)
  | at /home/theia/node_modules/@theia/plugin-ext/lib/hosted/node/hosted-plugin.js:99:28
  | at Array.forEach (<anonymous>)
  | at HostedPluginSupport.onMessage (/home/theia/node_modules/@theia/plugin-ext/lib/hosted/node/hosted-plugin.js:97:32)
  | at HostedPluginServerImpl.onMessage (/home/theia/node_modules/@theia/plugin-ext/lib/hosted/node/plugin-service.js:152:27)
  | at JsonRpcProxyFactory.onNotification (/home/theia/node_modules/@theia/core/lib/common/messaging/proxy-factory.js:246:36)
  | at /home/theia/node_modules/@theia/core/lib/common/messaging/proxy-factory.js:181:53
  | at handleNotification (/home/theia/node_modules/vscode-jsonrpc/lib/main.js:483:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tolusha tolusha merged commit b8fa90c into master Apr 16, 2019
@tolusha tolusha deleted the ab/djangosample branch April 16, 2019 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants