Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ TS-SELENIUM ] Investigating new typescript related test framework #13200

Merged
merged 63 commits into from
May 6, 2019
Merged

[ TS-SELENIUM ] Investigating new typescript related test framework #13200

merged 63 commits into from
May 6, 2019

Conversation

Ohrimenko1988
Copy link
Contributor

What does this PR do?

Implements new test solution (selenium-typescript + Mocha + Chai). And moves existed "Cypress" codebase to this framework

What issues does this PR fix or reference?

Issue: #13114

Release Notes

Docs PR

@Ohrimenko1988
Install basic tools
d706904 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Add 'Driver' definition
e4afc5b 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Add first pageobject
3cb248e 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Intermediate 'Selenium' + 'Mocha' + 'Chai' working version
ca8b301 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Intermediate 'Selenium' + 'Mocha' + 'Chai' working version
e307ce4 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Intermediate 'Selenium' + 'Mocha' + 'Chai' working version
8c2f2f5 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Intermediate 'Selenium' + 'Mocha' + 'Chai' working version
13b64e3 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Intermediate 'Selenium' + 'Mocha' + 'Chai' working version
269617f 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Intermediate 'Selenium' + 'Mocha' + 'Chai' working version
79b5a09 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Intermediate 'Selenium' + 'Mocha' + 'Chai' working version
aa98cff 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Merge branch 'master' of https://github.com/eclipse/che into typescri…
bd596ca 
…pt-selenium
@Ohrimenko1988
Intermediate 'Selenium' + 'Mocha' + 'Chai' working version
15853ec 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Intermediate 'Selenium' + 'Mocha' + 'Chai' working version
2dbc438 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Intermediate 'Selenium' + 'Mocha' + 'Chai' working version
10f011f 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Add launch customization possibility by environment variables set
e9fa3ff 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Add tests folder and create pattern for launch it
6f24843 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Do base URL configurable
cc8beca 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Update the 'DriverHelper' class
124e0cb 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Add 'mocha.opts' supporting
cbffa2f 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Add 'headless' mode supporting
6830399 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Add licence headers
3473987 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988 Ohrimenko1988 added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. team/che-qe labels Apr 22, 2019
@rhopp
Copy link
Contributor

rhopp commented Apr 26, 2019

ci-test

@Ohrimenko1988
Do changes according to review
48d5d0f 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@ashumilova ashumilova removed their request for review April 26, 2019 12:49
@che-bot
Copy link
Contributor

che-bot commented Apr 26, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13200
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@l0rd l0rd mentioned this pull request Apr 29, 2019
Closed
@Ohrimenko1988
Do changes according to review
19e0434 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Merge branch 'master' of https://github.com/eclipse/che into typescri…
708dde9 
…pt-selenium
@Ohrimenko1988
Do changes according to review
b4ce619 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Copy link
Contributor Author

ci-build

@Ohrimenko1988
Do changes according to changed java plugin id
1302bdc 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
Katka92
Katka92 reviewed May 3, 2019
View reviewed changes
typescript-selenium/pageobjects/dashboard/NewWorkspace.ts Outdated


@injectable()
export class NewWorkspace {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about changing the name to e.g. WorkspaceHandler and include the methods stopWorkspaceByUI and deleteWorkspaceByUI here too, so all the logic arount handling the workspace will be on once place? Or is there some reason to have it separated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "NewWorkspace" pageobject describes "NewWorkspace" page

Katka92
Katka92 reviewed May 3, 2019
View reviewed changes
typescript-selenium/tests/HappyPath.spec.ts Outdated
})

test("Add 'Java Language Support' plugin to workspace", async () => {
await workspaceDetailsPlugins.addPluginAndOpenWorkspace(namespace, workspaceName, javaPluginName, pluginId)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'll split this logic to two lines: addPlugins and openWorksapce because I don't think these operations are atomic and we maybe could want to add more plugins before opening workspace.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right, but we can't check that plugins are successfully added until workspace been run.

ppitonak
ppitonak suggested changes May 3, 2019
View reviewed changes
cypress-tests/cypress/pageobjects/ide/ProjectTree.ts Outdated
@@ -32,6 +32,14 @@ export class ProjectTree {
return `${this.getExpandIconLocator(itemPath)}:not(.theia-mod-collapsed)`;
}

private getExpandIconLocator(itemPath: string) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ohrimenko1988 are you going to address this?

typescript-selenium/driver/CheReporter.ts Outdated
const pageSourceFileName: string = `${testReportDirPath}/pagesource-${testTitle}.html`

//create reporter dir if not exist
await fs.exists(reportDirPath, async isDirExist => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From Node.js v10.12 you can use recursive version of mkdir which IMHO doesn't do anything if the directory already exists. Isn't fs.exists() call unnecessary? BTW v10 is now active LTS release so I suggest to use it.

@Ohrimenko1988
Copy link
Contributor Author

ci-build

@l0rd
Copy link
Contributor

l0rd commented May 6, 2019

Let's merge this PR and fix the technical debts refactorings in a separate PR

@Ohrimenko1988
Add new methods to the 'Editor' pageobject
659d2e5 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Rewert changesrelated to cypress module
3e0223c 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Merge branch 'master' of https://github.com/eclipse/che into typescri…
b25c53f 
…pt-selenium
@Ohrimenko1988
Do changes according to review
b3128c1 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Rename 'typescript-selenium' module to 'e2e' module
f4e5ca5 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988 Ohrimenko1988 merged commit 1def7da into master May 6, 2019
@Ohrimenko1988 Ohrimenko1988 deleted the typescript-selenium branch May 6, 2019 14:38
@Ohrimenko1988 Ohrimenko1988 mentioned this pull request May 6, 2019
Closed
@Ohrimenko1988 Ohrimenko1988 removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label May 6, 2019
@benoitf
Copy link
Contributor

benoitf commented May 16, 2019

hello,

what are the CQs for all the dependencies used in that PR ?
I also see caret ranges which is not compliant AFAIK with Eclipse policy about IP dependencies

@Ohrimenko1988
Copy link
Contributor Author

Ohrimenko1988 commented May 17, 2019 •
edited
Loading

Hello, CQ's for dependencies are in the pending state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Katka92 Katka92 Katka92 left review comments

@mmorhun mmorhun mmorhun left review comments

@AndrienkoAleksandr AndrienkoAleksandr AndrienkoAleksandr approved these changes

@ljelinkova ljelinkova ljelinkova left review comments

@musienko-maxim musienko-maxim musienko-maxim approved these changes

@ppitonak ppitonak ppitonak requested changes

@SkorikSergey SkorikSergey SkorikSergey approved these changes

@rhopp rhopp rhopp approved these changes

@dmytro-ndp dmytro-ndp Awaiting requested review from dmytro-ndp

@artaleks9 artaleks9 Awaiting requested review from artaleks9

@akurinnoy akurinnoy Awaiting requested review from akurinnoy

@vparfonov vparfonov Awaiting requested review from vparfonov

@benoitf benoitf Awaiting requested review from benoitf

Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.