Add the sidecar-plugins volume to enable remote plugin isolation
#13342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Festal <dfestal@redhat.com>
|
Do we really need two volumes? Can not we use one volume with two folders? Something like |
|
@sleshchenko I changed the plugin broker, and don't need the additional volume anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR provides an additional volume to plugin brokers so that, for more Theia and VsCode plugins, the plugin broker can isolate the the remote plugin extension archives from the main plugins directory related to the main Theia IDE container.
What issues does this PR fix or reference?
#13272
and the need is explained in the comment #12395 (comment), mainly the following part: