Update screencatcher in the e2e folder for avoiding errors #14394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
Ohrimenko1988
added
status/code-review
Ohrimenko1988
requested review from
l0rd,
musienko-maxim and
nickboldt
as code owners
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
dmytro-ndp
reviewed
Aug 30, 2019
| fs.mkdirSync(executionScreenCastErrorsDir); | ||
| } | ||
|
|
||
| let errorLogFilePath: string = screenshotPath.replace('.png', '.txt'); |
There was a problem hiding this comment.
Here we can just add .txt, or, more obvious, .error.log to the screenshotPath, to have file name like the follow:
0010002--(10:04:38.853): Open workspace.png.error.log
|
PR commonly looks good. I would only ask you to wait on results of PR check on CRW Jenkins CI before merging. |
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
|
crw-ci-test |
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
|
@Ohrimenko1988: there is Happy path tests error #14394 (comment):
|
|
Oh, you have fixed it recently. |
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
SkorikSergey
approved these changes
Aug 30, 2019
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
|
ci-test |
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
|
ci-test |
|
E2E tests of Eclipse Che Multiuser on OCP has been successful:
|
che-bot
removed
the
status/code-review
dmytro-ndp
pushed a commit
that referenced
this pull request
Sep 5, 2019
dmytro-ndp
added a commit
that referenced
this pull request
Sep 6, 2019
Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com> * Use eclipse/che-e2e:nightly to run Happy path tests on Jenkins CI Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com> * Decrease Happy path tests execution build timeout to 20 minutes Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com> * Use bujhtr5555/che-e2e:latest to check fixup Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com> * Fix che start command Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com> * Update screencatcher in the e2e folder for avoiding errors (#14394) * Fix mistake in the "activateBreakpoint" method Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com> * Rework method for enabling debug breakpoint Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com> * Cleanup code Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com> * Run tests from docker image Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com> * Run local tests mounted to docker image Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com> * Check tests with cypress/browsers:node8.9.3-chrome73 Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com> * check with eclipse/che-e2e:nightly Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com> * Run tests from inside eclipse/che-e2e:nightly Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com> * Check local e2e tests Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com> * Pre-pull eclipse/che-e2e:nightly Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com> * Check local tests with updated eclipse/che-e2e:nightly Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ihor Okhrimenko iokhrime@redhat.com
What does this PR do?
Update screencatcher in the e2e folder for avoiding errors
If screenshots store without errors, all works as before
If error happens, the error interrupts and stack trace stores in the separated folder and file
What issues does this PR fix or reference?
Issue: #14384
Release Notes
Docs PR