Add Ssh Api methods to list of allowed requests signed with machine token #14557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinokurig
requested review from
l0rd,
mshaposhnik,
nickboldt and
rhopp
as code owners
che-bot
added
status/code-review
…oken Signed-off-by: Igor Vinokur <ivinokur@redhat.com>
vinokurig
force-pushed
the
che-14332
branch
from
71c3874 to
945a770
Compare
mshaposhnik
approved these changes
Sep 16, 2019
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
|
Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/2303//Selenium_20tests_20report/) doesn't show any regression against this Pull request. |
6 tasks
che-bot
removed
the
status/code-review
musienko-maxim
pushed a commit
that referenced
this pull request
Sep 17, 2019
…oken (#14557) Che-theia SSH plugin uses createPair, getPairs, removePair API methods. Since the methods are not included to the list of allowed request that can be signed with machine token, the ssh plugin doesn't work properly.
musienko-maxim
pushed a commit
that referenced
this pull request
Sep 17, 2019
…oken (#14557) Che-theia SSH plugin uses createPair, getPairs, removePair API methods. Since the methods are not included to the list of allowed request that can be signed with machine token, the ssh plugin doesn't work properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Che-theia SSH plugin uses
createPair,getPairs,removePairAPI methods. Since the methods are not included to the list of allowed request that can be signed with machine token, the ssh plugin doesn't work properly.What issues does this PR fix or reference?
fixes #14332
Release Notes
Docs PR