Use newer che-plugin-broker with che-theia remote runtime injection #14832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
AndrienkoAleksandr
requested review from
ibuziuk,
l0rd,
nickboldt and
rhopp
as code owners
che-bot
added
status/code-review
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
sleshchenko
approved these changes
Oct 9, 2019
|
ci-build |
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
|
ci-test |
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
amisevsk
approved these changes
Oct 9, 2019
musienko-maxim
approved these changes
Oct 10, 2019
AndrienkoAleksandr
deleted the
usePluginBrokerWithCheTheiaRemoteRuntimeInjection
branch
che-bot
removed
the
status/code-review
|
The test failed because we got new changes from upstream and test is not been adapted yet. The same in master. I don't see regression in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use newer che-plugin-broker with che-theia remote runtime injection. P.S. runtime injection begin work when we will merge init container for che-theia editor eclipse-che/che-plugin-registry#233, otherwise che-theia works in an old way.
What issues does this PR fix or reference?
#13387
Signed-off-by: Oleksandr Andriienko oandriie@redhat.com