Support ENV variables in cheEditor/chePlugin components of the devfile #15401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshaposhnik
requested review from
sleshchenko,
metlos,
skabashnyuk and
sparkoo
che-bot
added
the
status/code-review
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
|
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) ℹ️ |
metlos
reviewed
Dec 5, 2019
| if (isNullOrEmpty(envVars)) { | ||
| return null; | ||
| } | ||
| return Stream.of(envVars.split(",")) |
There was a problem hiding this comment.
This breaks on , contained in the envvar value, right? IMHO that could render some JAVA_OPTS invalid, because e.g. settings for -agentlib or -javaagent are usually comma separated.
There was a problem hiding this comment.
Yeah, that is the problem. Also another example is LDAP namespaces like myDN=OU=MY_OU,DC=MYDC,DC=local
|
Closing in favor of #15435 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Support ENV variables in cheEditor/chePlugin components of the devfile
What issues does this PR fix or reference?