Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove selfSignedCertSecretName property #15878

Merged
merged 2 commits into from
Feb 26, 2020
+7 −8
Merged

Remove selfSignedCertSecretName property #15878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8da3276
Remove selfSignedCertSecretName property
mmorhun Jan 24, 2020
378c28b
Fix propagating of TLS certificate for workspaces ingresses
sleshchenko Feb 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions deploy/kubernetes/helm/che/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,24 +100,24 @@ spec:
valueFrom:
secretKeyRef:
key: ca.crt
name: {{ .Values.global.tls.selfSignedCertSecretName }}
name: {{ .Values.global.tls.secretName }}
optional: false
{{- end }}

# If workspaces are created in a separate precreated namespace
# If workspaces are created in a separate namespace(s)
# then configure Che Server to propagate TLS secret to workspaces' namespaces
{{- if not (contains "<" .Values.global.cheWorkspacesNamespace) }}
{{- if ne .Release.Namespace .Values.global.cheWorkspacesNamespace }}
- name: "CHE_INFRA_KUBERNETES_TLS__CERT"
valueFrom:
secretKeyRef:
key: tls.crt
name: {{ .Values.global.tls.secretName }}
name: {{ .Values.global.tls.secretName }}
optional: false
- name: "CHE_INFRA_KUBERNETES_TLS__KEY"
valueFrom:
secretKeyRef:
key: tls.key
name: {{ .Values.global.tls.secretName }}
name: {{ .Values.global.tls.secretName }}
optional: false
{{- end }}
{{- end }}
Expand Down
5 changes: 2 additions & 3 deletions deploy/kubernetes/helm/che/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,9 @@ global:
## it MUST be pre-created in the configured Che namespace
secretName: che-tls

## If self-signed certificate is enabled
## then certificate from `tls.selfSignedCertSecretName` will be propagated to Che components' trust stores
## If self-signed certificate flag is enabled
## then CA certificate from `tls.secretName` will be propagated to Che components' trust stores
useSelfSignedCerts: false
selfSignedCertSecretName: self-signed-cert


## If using git self-signed certificate is enabled
Expand Down