Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize some happy path tests at update to the latest Theia #17933

Merged
merged 2 commits into from
Sep 24, 2020
Merged

Stabilize some happy path tests at update to the latest Theia #17933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c39a0b
Add action to 'Build application with changes' test
RomanNikitenko Sep 22, 2020
04d0ac4
Change selector at clicking on terminal tab
RomanNikitenko Sep 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/e2e/pageobjects/ide/Terminal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export class Terminal {
async clickOnTab(tabTitle: string, timeout: number = TimeoutConstants.TS_SELENIUM_TERMINAL_DEFAULT_TIMEOUT) {
Logger.debug(`Terminal.clickOnTab "${tabTitle}"`);

const terminalTabLocator: By = By.css(this.getTerminalTabCssLocator(tabTitle));
const terminalTabLocator: By = By.css(`${this.getTerminalTabCssLocator(tabTitle)} div.theia-tab-icon-label`);

await this, this.driverHelper.waitAndClick(terminalTabLocator, timeout);
}
Expand Down
1 change: 1 addition & 0 deletions tests/e2e/tests/e2e_happy_path/HappyPath.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,7 @@ suite('Display source code changes in the running application', async () => {

test('Build application with changes', async () => {
await topMenu.runTask('build');
await projectTree.clickOnItem(projectName + '/src/main/java');
await projectTree.collapseProjectTree(projectName + '/src', 'main');
await projectTree.expandPathAndOpenFile(projectName, 'result-build.txt', 300_000);
await editor.waitText('result-build.txt', '[INFO] BUILD SUCCESS');
Expand Down