Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Terminal.ts #17949

Closed
wants to merge 1 commit into from
Closed

Update Terminal.ts #17949

wants to merge 1 commit into from

Conversation

dmytro-ndp
Copy link
Contributor

@dmytro-ndp dmytro-ndp commented Sep 24, 2020 •
edited
Loading

@dmytro-ndp
Update Terminal.ts
4b09aeb 
Move css changes to getTerminalTabCssLocator()
@che-bot che-bot added kind/enhancement A feature request - must adhere to the feature request template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. target/branch Indicates that a PR will be merged into a branch other than master. labels Sep 24, 2020
RomanNikitenko
RomanNikitenko reviewed Sep 24, 2020
View reviewed changes
tests/e2e/pageobjects/ide/Terminal.ts
@@ -124,7 +124,7 @@ export class Terminal {
}

private getTerminalTabCssLocator(tabTitle: string): string {
return `li[title='${tabTitle}']`;
return `li[title='${tabTitle}'] div.theia-tab-icon-label`;
Copy link
Member

@RomanNikitenko RomanNikitenko Sep 24, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it can break some cases, here, for example
so, let's check it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait on test results https://codeready-workspaces-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/Multiuser-Che-PR-check-E2E-Happy-path-tests-against-k8s/3617/

@dmytro-ndp
Copy link
Contributor Author

[crw-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Sep 24, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

@dmytro-ndp
Copy link
Contributor Author

Happy path tests failed:

12:46:50     1) Close the terminal running tasks
12:46:50 
12:46:50 
12:46:50   11 passing (7m)
12:46:50   1 pending
12:46:50   1 failing
12:46:50 
12:46:50   1) Validation of workspace build and run
12:46:50        Close the terminal running tasks:
12:46:50      TimeoutError: Exceeded maximum clicking attempts, the 'By(css selector, li[title='build-file-output'] div.theia-tab-icon-label div.p-TabBar-tabCloseIcon)' element is not clickable
12:46:50       at DriverHelper.waitAndClick (/tmp/e2e/utils/DriverHelper.ts:291:15)
12:46:50       at <anonymous>
12:46:50       at process._tickCallback (internal/process/next_tick.js:188:7)

So, I am closing PR.

@dmytro-ndp dmytro-ndp closed this Sep 24, 2020
@dmytro-ndp dmytro-ndp deleted the dmytro-ndp-patch-1 branch December 2, 2020 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomanNikitenko RomanNikitenko RomanNikitenko left review comments

@l0rd l0rd Awaiting requested review from l0rd

@musienko-maxim musienko-maxim Awaiting requested review from musienko-maxim

@nickboldt nickboldt Awaiting requested review from nickboldt

@Ohrimenko1988 Ohrimenko1988 Awaiting requested review from Ohrimenko1988

@rhopp rhopp Awaiting requested review from rhopp

Assignees
No one assigned
Labels
kind/enhancement A feature request - must adhere to the feature request template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmytro-ndp @che-bot @RomanNikitenko