Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect changes of dialog font #13

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Respect changes of dialog font #13

wants to merge 2 commits into from

Conversation

Godin
Copy link
Member

@Godin Godin commented Jan 22, 2017

No description provided.

@Godin Godin requested a review from marchof January 22, 2017 19:17
@Godin
Copy link
Member Author

Godin commented Jan 24, 2017

@marchof could you please review?

@marchof
Copy link
Contributor

marchof commented Jan 25, 2017

@Godin Looks like not all labels in the settings dialog adopt the dialog font:

settings

@marchof
Copy link
Contributor

marchof commented Jan 25, 2017

@Godin I remember that I had similar problems to capture all font occurrences.

Same issue for the select buttons in the coverage dialog:

coverage

@marchof
Copy link
Contributor

marchof commented Jan 25, 2017

@Godin The session name on our properties page:

properties

@marchof
Copy link
Contributor

marchof commented Jan 25, 2017

@Godin The other dialogs (import, export, merge, select) look good to me though!

@Godin
Copy link
Member Author

Godin commented Jan 25, 2017

@marchof that's strange - I not just added automated tests, but also tested manually by changing font size significantly, however only on Linux, not on Mac.

But never mind - I'll retest/rework. Good catches, thanks!

@Godin Godin self-assigned this Jan 25, 2017
@Godin
Copy link
Member Author

Godin commented Jan 26, 2017

@marchof this starts to be interesting 😆

Manual test on Linux using Eclipse Platform (Version: Oxygen (4.7) Build id: I20160915-0230):

preferencepage

launchingtab

propertypage

Will try Mac later...

@Godin
Copy link
Member Author

Godin commented Jan 26, 2017

Even simply execution of automated UI test confirms problem on Mac.

@Godin
Copy link
Member Author

Godin commented Jan 26, 2017

According to JavaDoc of Dialog.applyDialogFont

Applies the dialog font to all controls that currently have the default font. Font will also be applied to its children.

so the call is placed correctly at the end.

What driving me crazy - removal of

@@ -138,7 +138,6 @@ public class CoveragePreferencePage extends FieldEditorPreferencePage
   private Group createGroup(final Composite parent, final String text) {
     final Group group = new Group(parent, SWT.NONE);
     group.setText(text);
-    group.setFont(parent.getFont());
     GridDataFactory.fillDefaults().applyTo(group);
     group.setLayoutData(new GridData(GridData.FILL_HORIZONTAL));
     return group;

assuming that this is the place that changes value from default, leads to a really strange result:

before_png__423x564__and_after_png__419x532_

@marchof
Copy link
Contributor

marchof commented Feb 2, 2017

@Godin How should we proceed here? Do we apply a "best effort" fix and hope the platform will fix the problem for Mac?

@Godin
Copy link
Member Author

Godin commented Feb 2, 2017

@marchof I still plan to make it work properly on OS X.

@Godin Godin marked this pull request as draft June 6, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants