Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test that fails since Eclipse 4.14 #35

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Fix test that fails since Eclipse 4.14 #35

merged 1 commit into from
Oct 30, 2023

Conversation

Godin
Copy link
Member

@Godin Godin commented Oct 30, 2023

Before this change JavaApplicationLauncherTest.testProjectWithLibrary fails when targeting Eclipse 4.14 and newer

mvn verify -Pe4.14

leads to

testProjectWithLibrary(org.eclipse.eclemma.core.launching.JavaApplicationLauncherTest)  Time elapsed: 1.473 s  <<< FAILURE!
java.lang.AssertionError: expected: java.util.HashSet<[sample.jar (not open) [in project1]]> but was: java.util.HashSet<[sample.jar (not open) [in project1]]>
        at org.eclipse.eclemma.core.launching.JavaApplicationLauncherTest.testProjectWithLibrary(JavaApplicationLauncherTest.java:119)

@Godin Godin requested a review from marchof October 30, 2023 11:00
@Godin Godin self-assigned this Oct 30, 2023
@Godin Godin marked this pull request as ready for review October 30, 2023 11:10
@Godin Godin force-pushed the fix_JavaApplicationLauncherTest_testProjectWithLibrary branch from 2844e74 to 2ca98ff Compare October 30, 2023 14:58
@marchof marchof merged commit daa5334 into eclipse-eclemma:master Oct 30, 2023
1 check passed
@Godin Godin deleted the fix_JavaApplicationLauncherTest_testProjectWithLibrary branch October 30, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marchof marchof marchof approved these changes

Assignees

@Godin Godin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Godin @marchof