Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Tycho to 3.0.5 #41

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

Godin
Copy link
Member

@Godin Godin commented Nov 6, 2023

No description provided.

@Godin Godin requested a review from marchof November 6, 2023 10:02
@Godin Godin self-assigned this Nov 6, 2023
@marchof
Copy link
Contributor

marchof commented Nov 6, 2023

How doe this relate to the Java 17 update? This is only for Tycho execution or does it change the compile targat?

@Godin
Copy link
Member Author

Godin commented Nov 6, 2023

@marchof Tycho 3.x requires Java 17 for execution.

Quoting Tycho documentation

MANIFEST header Bundle-RequiredExecutionEnvironment is used to define the JDK to compile against.

our Bundle-RequiredExecutionEnvironment is still J2SE-1.5
and after this change output of

javap -v -p org.eclipse.eclemma.core/target/classes/org/eclipse/eclemma/internal/core/EclEmmaCorePlugin.class | grep major
javap -v -p org.eclipse.eclemma.ui/target/classes/org/eclipse/eclemma/internal/ui/EclEmmaUIPlugin.class | grep major

is still

  major version: 49
  major version: 49

Moreover, for quite some time we already have been using Tycho 2.7.5 which requires Java 11 for execution 😉

@marchof marchof merged commit 6b89446 into eclipse-eclemma:master Nov 7, 2023
3 checks passed
@Godin Godin deleted the upgrade_tycho branch November 7, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants