Skip to content

Commit

Permalink
feat(vault): review suggestions
Browse files Browse the repository at this point in the history
Signed-off-by: Sascha Isele <s.isele@cluetec.de>
  • Loading branch information
SaschaIsele committed Sep 9, 2024
1 parent 1de44d3 commit 9b53e68
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public class HashicorpVaultExtension implements ServiceExtension {
@Setting(value = "The URL path of the vault's /secret endpoint", defaultValue = VAULT_API_SECRET_PATH_DEFAULT)
public static final String VAULT_API_SECRET_PATH = "edc.vault.hashicorp.api.secret.path";

@Setting(value = "The path of the folder that the secret is stored in", required = false, defaultValue = "")
@Setting(value = "The path of the folder that the secret is stored in, relative to VAULT_FOLDER_PATH")
public static final String VAULT_FOLDER_PATH = "edc.vault.hashicorp.folder";

@Inject
Expand Down Expand Up @@ -147,7 +147,7 @@ private HashicorpVaultSettings getSettings(ServiceExtensionContext context) {
var ttl = context.getSetting(VAULT_TOKEN_TTL, VAULT_TOKEN_TTL_DEFAULT);
var renewBuffer = context.getSetting(VAULT_TOKEN_RENEW_BUFFER, VAULT_TOKEN_RENEW_BUFFER_DEFAULT);
var secretPath = context.getSetting(VAULT_API_SECRET_PATH, VAULT_API_SECRET_PATH_DEFAULT);
var folderPath = context.getSetting(VAULT_FOLDER_PATH, "");
var folderPath = context.getSetting(VAULT_FOLDER_PATH, null);

return HashicorpVaultSettings.Builder.newInstance()
.url(url)
Expand Down

0 comments on commit 9b53e68

Please sign in to comment.