feat: define runtime id as a configurable setting #4157
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Add a new configuration setting called
edc.runtime.id
, that will replaceedc.connector.name
Why it does that
edc.connector.name
was not really used for its purpose, instead of being the name of the connector was used asleaseHolder
for sql lease, so I generalized its concept calling itedc.runtime.id
because its an Id that represent a specific runtime, that could be used in clustered environments to allow idempotence.Specifically, it will be used by data-planes for self-registration. (see #4031)
Further notes
DefaultServiceContext
is not optimal, there could be a dedicated component that could do that (like theExtensionLoader
) so the context could be instantiated with aConfig
instance passed. This will untangle some knots and will improve testing (issue will come)Linked Issue(s)
Closes #4156
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.