Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: define runtime id as a configurable setting #4157

Merged
merged 2 commits into from
May 6, 2024

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented May 3, 2024

What this PR changes/adds

Add a new configuration setting called edc.runtime.id, that will replace edc.connector.name

Why it does that

edc.connector.name was not really used for its purpose, instead of being the name of the connector was used as leaseHolder for sql lease, so I generalized its concept calling it edc.runtime.id because its an Id that represent a specific runtime, that could be used in clustered environments to allow idempotence.
Specifically, it will be used by data-planes for self-registration. (see #4031)

Further notes

  • the way the configuration is loaded inside the DefaultServiceContext is not optimal, there could be a dedicated component that could do that (like the ExtensionLoader) so the context could be instantiated with a Config instance passed. This will untangle some knots and will improve testing (issue will come)

Linked Issue(s)

Closes #4156

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added the enhancement New feature or request label May 3, 2024
@ndr-brt ndr-brt requested a review from wolf4ood May 3, 2024 12:09
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 19.07%. Comparing base (7f20ba5) to head (623a396).
Report is 239 commits behind head on main.

Files Patch % Lines
...dc/boot/system/DefaultServiceExtensionContext.java 0.00% 11 Missing ⚠️
...saction/atomikos/AtomikosTransactionExtension.java 0.00% 2 Missing ⚠️
...g/eclipse/edc/boot/system/runtime/BaseRuntime.java 0.00% 1 Missing ⚠️
...eclipse/edc/iam/oauth2/Oauth2ServiceExtension.java 0.00% 1 Missing ⚠️
...otiation/SqlContractNegotiationStoreExtension.java 0.00% 1 Missing ⚠️
...nsferprocess/SqlTransferProcessStoreExtension.java 0.00% 1 Missing ⚠️
...ataplane/store/sql/SqlDataPlaneStoreExtension.java 0.00% 1 Missing ⚠️
...itor/store/sql/SqlPolicyMonitorStoreExtension.java 0.00% 1 Missing ⚠️
...clipse/edc/spi/system/ServiceExtensionContext.java 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4157       +/-   ##
===========================================
- Coverage   71.74%   19.07%   -52.67%     
===========================================
  Files         919      986       +67     
  Lines       18457    20267     +1810     
  Branches     1037     1144      +107     
===========================================
- Hits        13242     3866     -9376     
- Misses       4756    16288    +11532     
+ Partials      459      113      -346     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndr-brt ndr-brt force-pushed the 4156-add-runtime-id branch from 623a396 to 3a3784e Compare May 6, 2024 10:02
@ndr-brt ndr-brt merged commit 3be69e7 into eclipse-edc:main May 6, 2024
16 checks passed
@ndr-brt ndr-brt deleted the 4156-add-runtime-id branch May 6, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unique UUID to dataplane configuration for idempotent self-registration
5 participants