Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add not-equals (!=) operator #4164

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

Adds the "not-equals" or "!=" operator to our default operator portfolio

Why it does that

General functional completeness, but there is one particular use case: when querying for VerifiableCredentials, we only want those where the status is not "REVOKED" and not "EXPIRED".

If we wanted to "cross all t's and dot all i's" we'd also have to add a "not-in" operator, but this seems good enough for now and keeps the complexity down.

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #4163

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger requested a review from ndr-brt as a code owner May 6, 2024 16:27
@paullatzelsperger paullatzelsperger added this to the Backlog milestone May 6, 2024
@paullatzelsperger paullatzelsperger added the enhancement New feature or request label May 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 74.93%. Comparing base (7f20ba5) to head (655235f).
Report is 243 commits behind head on main.

Files Patch % Lines
...lipse/edc/query/CriterionOperatorRegistryImpl.java 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4164      +/-   ##
==========================================
+ Coverage   71.74%   74.93%   +3.18%     
==========================================
  Files         919      989      +70     
  Lines       18457    20285    +1828     
  Branches     1037     1146     +109     
==========================================
+ Hits        13242    15200    +1958     
+ Misses       4756     4587     -169     
- Partials      459      498      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paullatzelsperger paullatzelsperger merged commit 873e86b into eclipse-edc:main May 7, 2024
16 checks passed
@paullatzelsperger paullatzelsperger deleted the feat/4163_add_not_equals_operator branch May 7, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "not-equals" operator predicate
3 participants