Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add stateTimestamp to translation model #4165

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

adds the stateTimestamp to the translation model for stateful entities (StatefulEntityMapping).

Why it does that

sorting stateful entities by stateTimestamp threw an IllegalArgumentException, because the translation model did not
contain a corresponding mapping.

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added the bug Something isn't working label May 7, 2024
@paullatzelsperger paullatzelsperger requested a review from ndr-brt as a code owner May 7, 2024 19:59
@paullatzelsperger paullatzelsperger requested a review from wolf4ood May 7, 2024 19:59
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 75.01%. Comparing base (7f20ba5) to head (cdb7c29).
Report is 247 commits behind head on main.

Files Patch % Lines
...g/eclipse/edc/sql/lease/StatefulEntityMapping.java 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4165      +/-   ##
==========================================
+ Coverage   71.74%   75.01%   +3.27%     
==========================================
  Files         919     1007      +88     
  Lines       18457    20454    +1997     
  Branches     1037     1151     +114     
==========================================
+ Hits        13242    15344    +2102     
+ Misses       4756     4609     -147     
- Partials      459      501      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paullatzelsperger paullatzelsperger requested a review from ndr-brt May 8, 2024 07:19
@paullatzelsperger paullatzelsperger merged commit 20c2794 into eclipse-edc:main May 8, 2024
16 checks passed
@paullatzelsperger paullatzelsperger deleted the fix/add_statetimestamp_to_translation_model branch May 8, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants