refactor(api): move data plane select functionality to control api #4189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
added
refactoring
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| DataPlaneInstance select(DataAddress source, DataAddress destination, @Nullable String selectionStrategy, @Nullable String transferType); | ||
|
|
||
| @Deprecated(since = "0.6.4") | ||
| default DataPlaneInstance select(DataAddress source, DataAddress destination, @Nullable String selectionStrategy, @Nullable String transferType) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4189 +/- ##
==========================================
+ Coverage 71.74% 74.99% +3.25%
==========================================
Files 919 1015 +96
Lines 18457 20631 +2174
Branches 1037 1161 +124
==========================================
+ Hits 13242 15473 +2231
+ Misses 4756 4651 -105
- Partials 459 507 +48 ☔ View full report in Codecov by Sentry. |
ndr-brt
force-pushed
the
4177-data-plane-selector-control-api
branch
from
d7bad75 to
1044d45
Compare
ndr-brt
force-pushed
the
4177-data-plane-selector-control-api
branch
from
1044d45 to
1833335
Compare
...pse/edc/connector/controlplane/transfer/dataplane/flow/DataPlaneSignalingFlowController.java
Show resolved
Hide resolved
...pse/edc/connector/controlplane/transfer/dataplane/flow/DataPlaneSignalingFlowController.java
Outdated
Show resolved
Hide resolved
...java/org/eclipse/edc/connector/dataplane/selector/api/v2/DataplaneSelectorApiController.java
Outdated
Show resolved
Hide resolved
.../edc/connector/dataplane/selector/control/api/DataplaneSelectorControlApiControllerTest.java
Show resolved
Hide resolved
paullatzelsperger
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Add
selectandgetAllfunctionality to dataplane selectorcontrol-api, and deprecateselecton themanagement-apiWhy it does that
Separation of responsibilities.
Further notes
DataPlaneSelectorServicereturnServiceResult, this makes the interaction of theRemoteimplementation more consistent, because there could be situations (unlike with theEmbeddedone) where the communication with the server fails.destinationfrom the dataplane selection request, because it is not really necessary (source and transferType are enough)DataPlaneSignalingFlowControllerI left a TODO for a refactoring about the way the DataPlaneClient is created (in my opinion dataplaneselection should be encapsulated in the factory, so the condition "is data plane embedded" will be more explicit and testableLinked Issue(s)
Closes #4177
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.