Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(api): fix secrets api doc #4204

Merged
merged 1 commit into from
May 22, 2024

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented May 22, 2024

What this PR changes/adds

nothing fancy, just removing the overloaded name value, because as it was done it reported the full namespaced parameter name on the schema, but we usually report only the "compacted" version attribute name (in this case simply value).

Why it does that

documentation consistency

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added documentation Improvements or additions to documentation api Feature related to the (REST) api labels May 22, 2024
@ndr-brt ndr-brt requested a review from wolf4ood May 22, 2024 13:38
@ndr-brt ndr-brt merged commit 9210a69 into eclipse-edc:main May 22, 2024
18 checks passed
@ndr-brt ndr-brt deleted the fix-secrets-api-docs branch May 22, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Feature related to the (REST) api documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants