feat: bump the Dataplane Selector management API endpoints to v3
#4215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
added
enhancement
paullatzelsperger
added
the
breaking-change
paullatzelsperger
force-pushed
the
feat/bump_dataplane_selector_api_to_v3
branch
from
48af47f to
6cc3d8a
Compare
paullatzelsperger
force-pushed
the
feat/bump_dataplane_selector_api_to_v3
branch
from
c89e631 to
f909af9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4215 +/- ##
==========================================
+ Coverage 71.74% 75.35% +3.60%
==========================================
Files 919 1040 +121
Lines 18457 20677 +2220
Branches 1037 1151 +114
==========================================
+ Hits 13242 15581 +2339
+ Misses 4756 4584 -172
- Partials 459 512 +53 ☔ View full report in Codecov by Sentry. |
ndr-brt
approved these changes
May 27, 2024
wolf4ood
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Bumps the
DataPlaneSelectorApifrom/v2 -> /v3, deprecating/v2.the V3 Controller does not contain deprecated methods of the V2 Controller!
Why it does that
Briefly state why the change was necessary.
Further notes
operationIdproperty of endpoints - this is a breaking changeLinked Issue(s)
Closes #4208
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.