-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace File.separator with forward-slash #4221
fix: replace File.separator with forward-slash #4221
Conversation
@stefan1207 FYI |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4221 +/- ##
==========================================
+ Coverage 71.74% 75.35% +3.61%
==========================================
Files 919 1039 +120
Lines 18457 20636 +2179
Branches 1037 1152 +115
==========================================
+ Hits 13242 15551 +2309
+ Misses 4756 4574 -182
- Partials 459 511 +52 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused, shouldn't be \
the working separator on windows (that should be returned by File.separator
on win systems)?
no, because it's not a path on the actual file system, but a relative path inside the jar file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazed by how win can still surprise me after these years! :D
What this PR changes/adds
Replaces the
File.separator
with a hard-coded forward slash, to avoid path errors on Windows.Why it does that
Briefly state why the change was necessary.
Further notes
Linked Issue(s)
Closes #4219
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.