Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add findById method on DataPlaneSelectorService #4225

Merged
merged 1 commit into from
May 30, 2024

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented May 30, 2024

What this PR changes/adds

Add findById method on DataPlaneSelectorService

Why it does that

Avoid unnecessary calls to getAll

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #4210

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added enhancement New feature or request refactoring Cleaning up code and dependencies api Feature related to the (REST) api labels May 30, 2024
@ndr-brt ndr-brt requested review from wolf4ood and jimmarino May 30, 2024 08:25
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 75.36%. Comparing base (7f20ba5) to head (f9730db).
Report is 283 commits behind head on main.

Files Patch % Lines
...plane/selector/RemoteDataPlaneSelectorService.java 84.61% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4225      +/-   ##
==========================================
+ Coverage   71.74%   75.36%   +3.62%     
==========================================
  Files         919     1039     +120     
  Lines       18457    20640    +2183     
  Branches     1037     1152     +115     
==========================================
+ Hits        13242    15556    +2314     
+ Misses       4756     4573     -183     
- Partials      459      511      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wolf4ood wolf4ood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ndr-brt ndr-brt merged commit 4efd6ae into eclipse-edc:main May 30, 2024
18 checks passed
@ndr-brt ndr-brt deleted the 4210-selector-findby branch May 30, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Feature related to the (REST) api enhancement New feature or request refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add findById method on DataPlaneSelectorService
4 participants