Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly reset HealthStatus of BaseRuntime #4229

Conversation

paullatzelsperger
Copy link
Member

@paullatzelsperger paullatzelsperger commented Jun 3, 2024

What this PR changes/adds

This correctly sets the HealthCheckResult of the base runtime to succeeeded, where previously it was initially set to failure, but later
the builder method success() was called, which caused the resulting result to contain a failure and a success=true flag.

This in turn was interpreted as failure by the HealthCheckService.

Why it does that

Docker images never became healthy, causing our nightly builds to fail, specifically IdentityHub and FederatedCatalog.

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added the bug Something isn't working label Jun 3, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.36%. Comparing base (7f20ba5) to head (31eb74a).
Report is 285 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4229      +/-   ##
==========================================
+ Coverage   71.74%   75.36%   +3.62%     
==========================================
  Files         919     1039     +120     
  Lines       18457    20638    +2181     
  Branches     1037     1152     +115     
==========================================
+ Hits        13242    15554    +2312     
+ Misses       4756     4573     -183     
- Partials      459      511      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paullatzelsperger paullatzelsperger merged commit 968f138 into eclipse-edc:main Jun 3, 2024
19 of 20 checks passed
@paullatzelsperger paullatzelsperger deleted the fix/reset_health_status_of_baseruntime branch June 3, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants