Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add alias for issuance date #4254

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

Adds a JSON alias validFrom for the issuance date of a VerifiableCredential to compensate a vagueness in the StatusList2021 spec:

  • VC Datamodel 1.1 requires a issuanceDate field
  • VC Datamodel 2.0 requires a validFrom field
  • StatusList2021 explicitly mentions the VC Datamodel 1.1 as normative reference
  • StatusList2021 requires a validFrom field, which would violate the previous spec
  • StatusList2021 uses yet another option, an issued field in its examples

This is quite inconsistent, and so far EDC could accomodate issuanceDate and issued, but not validFrom. This PR changes that.

Why it does that

VCs are not always parsed using the Json-LD transformers: when we fetch a StatusList2021Credential it is parsed using standard Jackson features.

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added enhancement New feature or request dcp labels Jun 10, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.03%. Comparing base (7f20ba5) to head (37f6e54).
Report is 297 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4254      +/-   ##
==========================================
+ Coverage   71.74%   75.03%   +3.28%     
==========================================
  Files         919     1046     +127     
  Lines       18457    20980    +2523     
  Branches     1037     1169     +132     
==========================================
+ Hits        13242    15742    +2500     
+ Misses       4756     4726      -30     
- Partials      459      512      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paullatzelsperger paullatzelsperger merged commit 6034040 into eclipse-edc:main Jun 10, 2024
18 checks passed
@paullatzelsperger paullatzelsperger deleted the feat/alias_validFrom_in_vc branch June 10, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dcp enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants