Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(api): deprecate TransferRequest assetId #4269

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Jun 13, 2024

What this PR changes/adds

Deprecates TransferRequest.assetId attribute on management api.
Upgrades api version to 3.0.1.
Remove assetId from the TransferRequest value object and replace its usages with the policy target (that has the same value)

Why it does that

cleanup

Further notes

  • improve RuntimeExtension a little, to permit better usage of the RuntimePerClassExtension (as shown in the TransferProcessEventDispatchTest)
  • replaced some EdcRuntimeExtension occurrencies

Linked Issue(s)

Closes #4267

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added refactoring Cleaning up code and dependencies api Feature related to the (REST) api labels Jun 13, 2024
@ndr-brt ndr-brt requested review from wolf4ood and bscholtes1A June 13, 2024 12:38
@ndr-brt ndr-brt force-pushed the 4264-remove-asset-id branch from 69b557f to 815b2f2 Compare June 13, 2024 12:49
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.04%. Comparing base (7f20ba5) to head (815b2f2).
Report is 303 commits behind head on main.

Files Patch % Lines
...eclipse/edc/junit/extensions/RuntimeExtension.java 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4269      +/-   ##
==========================================
+ Coverage   71.74%   75.04%   +3.29%     
==========================================
  Files         919     1046     +127     
  Lines       18457    20982    +2525     
  Branches     1037     1171     +134     
==========================================
+ Hits        13242    15745    +2503     
+ Misses       4756     4724      -32     
- Partials      459      513      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndr-brt ndr-brt merged commit 40c67e8 into eclipse-edc:main Jun 14, 2024
18 checks passed
@ndr-brt ndr-brt deleted the 4264-remove-asset-id branch June 14, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Feature related to the (REST) api refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove TransferRequest assetId
3 participants