feat: implement Asset specialization #4297
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Asset#isCatalog()
@type
field and set theAsset#properties['isCatalog']
flag@type
field on egress ifAsset#properties['isCatalog']
istrue
CatalogAsset
is stored inAsset#properties
Why it does that
prepare for the next iteration, where
Dataset
extendsCatalog
Further notes
privateProperties
, but that would have made querying forCatalogAssets
impossible, because we currently can't query by private properties. If we don't care about querying, I'd suggest moving the flag back to theprivateProperties
EqualOperatorPredicate
can now handle booleansLinked Issue(s)
Closes #4295
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.