-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enhancing debug information for HttpDataSource transfers #4303
feat: Enhancing debug information for HttpDataSource transfers #4303
Conversation
...-plane-spi/src/main/java/org/eclipse/edc/connector/dataplane/spi/pipeline/StreamFailure.java
Outdated
Show resolved
Hide resolved
...-plane-spi/src/main/java/org/eclipse/edc/connector/dataplane/spi/pipeline/StreamFailure.java
Outdated
Show resolved
Hide resolved
...-plane-spi/src/main/java/org/eclipse/edc/connector/dataplane/spi/pipeline/StreamFailure.java
Show resolved
Hide resolved
a4732ad
to
793dbe2
Compare
...-plane-spi/src/main/java/org/eclipse/edc/connector/dataplane/spi/pipeline/StreamFailure.java
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4303 +/- ##
==========================================
+ Coverage 71.74% 75.20% +3.45%
==========================================
Files 919 1052 +133
Lines 18457 21116 +2659
Branches 1037 1181 +144
==========================================
+ Hits 13242 15880 +2638
+ Misses 4756 4720 -36
- Partials 459 516 +57 ☔ View full report in Codecov by Sentry. |
793dbe2
to
a97eb64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unit tests should stay as close as possible to the code, I wouldn't add them on PipelineServiceImpl
nor on ParallelSink
but on StreamFailure
directly.
I didn't do this because there is no test class dedicated to the |
Yes, there wasn't because it was not necessary, but now it will become |
7881fee
to
a0982ae
Compare
...ne-spi/src/test/java/org/eclipse/edc/connector/dataplane/spi/pipeline/StreamFailureTest.java
Show resolved
Hide resolved
...ne-spi/src/test/java/org/eclipse/edc/connector/dataplane/spi/pipeline/StreamFailureTest.java
Outdated
Show resolved
Hide resolved
please note that other tests around the codebase are broken |
...ne-spi/src/test/java/org/eclipse/edc/connector/dataplane/spi/pipeline/StreamFailureTest.java
Outdated
Show resolved
Hide resolved
...-plane-spi/src/main/java/org/eclipse/edc/connector/dataplane/spi/pipeline/StreamFailure.java
Outdated
Show resolved
Hide resolved
...ne-spi/src/test/java/org/eclipse/edc/connector/dataplane/spi/pipeline/StreamFailureTest.java
Outdated
Show resolved
Hide resolved
...ne-spi/src/test/java/org/eclipse/edc/connector/dataplane/spi/pipeline/StreamFailureTest.java
Outdated
Show resolved
Hide resolved
...ne-spi/src/test/java/org/eclipse/edc/connector/dataplane/spi/pipeline/StreamFailureTest.java
Outdated
Show resolved
Hide resolved
...ne-spi/src/test/java/org/eclipse/edc/connector/dataplane/spi/pipeline/StreamFailureTest.java
Outdated
Show resolved
Hide resolved
...ne-spi/src/test/java/org/eclipse/edc/connector/dataplane/spi/pipeline/StreamFailureTest.java
Outdated
Show resolved
Hide resolved
a0982ae
to
1b9d5ba
Compare
...ne-spi/src/test/java/org/eclipse/edc/connector/dataplane/spi/pipeline/StreamFailureTest.java
Outdated
Show resolved
Hide resolved
...ne-spi/src/test/java/org/eclipse/edc/connector/dataplane/spi/pipeline/StreamFailureTest.java
Outdated
Show resolved
Hide resolved
@zub4t Tests are failing, please fix them. |
40343b5
to
a0362cf
Compare
a0362cf
to
a022b3e
Compare
317309e
to
a022b3e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR changes/adds
Appends the reason for the error to the message that will be sent to the user when the transfer fails
Why it does that
To improve the user experience by returning some feedback when the
StreamResult
has no message associated with itLinked Issue(s)
Closes #4280