-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: unbind public endpoint generator from source address type #4315
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4315 +/- ##
==========================================
+ Coverage 71.74% 75.21% +3.46%
==========================================
Files 919 1053 +134
Lines 18457 21135 +2678
Branches 1037 1184 +147
==========================================
+ Hits 13242 15896 +2654
+ Misses 4756 4722 -34
- Partials 459 517 +58 ☔ View full report in Codecov by Sentry. |
cf9e81d
to
59bf60a
Compare
59bf60a
to
afc2549
Compare
What this PR changes/adds
Choose
PublicEndpointGenerator
function by destination address type instead of source.BREAKING CHANGE
: a newtransfer_type_destination
column has been added to theedc_data_plane
table. By default its value should beHttpData
Why it does that
to permit PULL transfers sources to be different from
HttpData
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes #4310
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.