Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unbind public endpoint generator from source address type #4315

Merged
merged 5 commits into from
Jul 2, 2024

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Jul 1, 2024

What this PR changes/adds

Choose PublicEndpointGenerator function by destination address type instead of source.

BREAKING CHANGE: a new transfer_type_destination column has been added to the edc_data_plane table. By default its value should be HttpData

Why it does that

to permit PULL transfers sources to be different from HttpData

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #4310

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added the bug Something isn't working label Jul 1, 2024
@ndr-brt ndr-brt requested a review from bscholtes1A as a code owner July 1, 2024 12:34
@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 88.65979% with 11 lines in your changes missing coverage. Please review.

Project coverage is 75.21%. Comparing base (7f20ba5) to head (454cd3e).
Report is 335 commits behind head on main.

Files Patch % Lines
...pi/types/domain/transfer/DataFlowStartMessage.java 63.63% 3 Missing and 1 partial ⚠️
.../eclipse/edc/connector/dataplane/spi/DataFlow.java 0.00% 4 Missing ⚠️
...nsfer/TransferProcessDefaultServicesExtension.java 0.00% 1 Missing ⚠️
...aplane/framework/manager/DataPlaneManagerImpl.java 95.65% 0 Missing and 1 partial ⚠️
...o/JsonObjectToDataFlowStartMessageTransformer.java 88.88% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4315      +/-   ##
==========================================
+ Coverage   71.74%   75.21%   +3.46%     
==========================================
  Files         919     1053     +134     
  Lines       18457    21135    +2678     
  Branches     1037     1184     +147     
==========================================
+ Hits        13242    15896    +2654     
+ Misses       4756     4722      -34     
- Partials      459      517      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndr-brt ndr-brt requested a review from jimmarino as a code owner July 2, 2024 10:06
@ndr-brt ndr-brt force-pushed the 4310-public-endpoint branch 2 times, most recently from cf9e81d to 59bf60a Compare July 2, 2024 12:36
@ndr-brt ndr-brt force-pushed the 4310-public-endpoint branch from 59bf60a to afc2549 Compare July 2, 2024 13:47
@ndr-brt ndr-brt added breaking-change Will require manual intervention for version update labels Jul 2, 2024
@ndr-brt ndr-brt merged commit 7abbdad into eclipse-edc:main Jul 2, 2024
22 checks passed
@ndr-brt ndr-brt deleted the 4310-public-endpoint branch July 2, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Will require manual intervention for version update bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PublicEndpointGenerator is bound to the source data address type
4 participants