Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cleanup 0.4.x deprecations #4354

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Jul 10, 2024

What this PR changes/adds

Delete 0.4.x deprecations

Why it does that

cleanup

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added the refactoring Cleaning up code and dependencies label Jul 10, 2024
@ndr-brt ndr-brt requested a review from wolf4ood July 10, 2024 15:25
@ndr-brt ndr-brt force-pushed the cleanup-deprecations branch 4 times, most recently from e9c80d2 to 5e559b3 Compare July 11, 2024 06:39
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 40.00000% with 54 lines in your changes missing coverage. Please review.

Project coverage is 75.24%. Comparing base (7f20ba5) to head (10a3c09).
Report is 352 commits behind head on main.

Files Patch % Lines
...onObjectToContractAgreementMessageTransformer.java 0.00% 12 Missing ⚠️
...tractNegotiationTerminationMessageTransformer.java 0.00% 12 Missing ⚠️
...tToContractNegotiationEventMessageTransformer.java 50.00% 6 Missing ⚠️
...JsonObjectToContractRequestMessageTransformer.java 0.00% 6 Missing ⚠️
...nObjectToTransferCompletionMessageTransformer.java 50.00% 6 Missing ⚠️
...o/JsonObjectToTransferStartMessageTransformer.java 50.00% 6 Missing ⚠️
...ObjectToTransferTerminationMessageTransformer.java 50.00% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4354      +/-   ##
==========================================
+ Coverage   71.74%   75.24%   +3.50%     
==========================================
  Files         919     1053     +134     
  Lines       18457    21089    +2632     
  Branches     1037     1157     +120     
==========================================
+ Hits        13242    15869    +2627     
+ Misses       4756     4701      -55     
- Partials      459      519      +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndr-brt ndr-brt force-pushed the cleanup-deprecations branch from 5e559b3 to 10a3c09 Compare July 11, 2024 07:52
Copy link
Member

@paullatzelsperger paullatzelsperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔪

Copy link
Contributor

@wolf4ood wolf4ood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪓

@ndr-brt ndr-brt merged commit 0fcb727 into eclipse-edc:main Jul 11, 2024
23 checks passed
@ndr-brt ndr-brt deleted the cleanup-deprecations branch July 11, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants