chore: fix catalog deserialization #4361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4361 +/- ##
==========================================
+ Coverage 71.74% 74.90% +3.16%
==========================================
Files 919 1063 +144
Lines 18457 21296 +2839
Branches 1037 1166 +129
==========================================
+ Hits 13242 15952 +2710
- Misses 4756 4823 +67
- Partials 459 521 +62 ☔ View full report in Codecov by Sentry. |
paullatzelsperger
approved these changes
Jul 12, 2024
ndr-brt
reviewed
Jul 12, 2024
| void verifySerialization() { | ||
| var catalog = createCatalog(); | ||
|
|
||
| var json = typeManager.writeValueAsString(catalog); |
There was a problem hiding this comment.
shouldn't we always use the JsonObjectFromCatalogTransformer to deserialize catalog?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
chore: fix catalog deserialization of
offersfield + testWhy it does that
bugfix