Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always record dataplane ID #4367

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

When sending the STARTED notification, the data plane ID should always be recorded.

Why it does that

consistency

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added the bug Something isn't working label Jul 17, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.92%. Comparing base (7f20ba5) to head (ae12ba1).
Report is 363 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4367      +/-   ##
==========================================
+ Coverage   71.74%   74.92%   +3.18%     
==========================================
  Files         919     1066     +147     
  Lines       18457    21381    +2924     
  Branches     1037     1171     +134     
==========================================
+ Hits        13242    16020    +2778     
- Misses       4756     4837      +81     
- Partials      459      524      +65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

This pull request is stale because it has been open for 7 days with no activity.

@github-actions github-actions bot added the stale Open for x days with no activity label Jul 25, 2024
@ndr-brt ndr-brt removed the stale Open for x days with no activity label Jul 25, 2024
@paullatzelsperger paullatzelsperger marked this pull request as ready for review July 29, 2024 07:07
@paullatzelsperger paullatzelsperger merged commit 417ad15 into eclipse-edc:main Jul 29, 2024
27 checks passed
@paullatzelsperger paullatzelsperger deleted the fix/always_record_dataplane branch July 29, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants