Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fail validation if muliple operands in a Logical Constraint are found #4371

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Jul 23, 2024

What this PR changes/adds

Add validation to avoid Logical Constraint with multiple operands

Why it does that

ODRL compliance

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #4370

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added the enhancement New feature or request label Jul 23, 2024
@ndr-brt ndr-brt requested a review from wolf4ood July 23, 2024 07:08
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.92%. Comparing base (7f20ba5) to head (c99337a).
Report is 364 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4371      +/-   ##
==========================================
+ Coverage   71.74%   74.92%   +3.18%     
==========================================
  Files         919     1066     +147     
  Lines       18457    21388    +2931     
  Branches     1037     1172     +135     
==========================================
+ Hits        13242    16025    +2783     
- Misses       4756     4839      +83     
- Partials      459      524      +65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndr-brt ndr-brt merged commit f9f4d18 into eclipse-edc:main Jul 23, 2024
18 of 20 checks passed
@ndr-brt ndr-brt deleted the 4370-multiple-logical-operands-validation branch July 23, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add validation for policy to avoid invalid logic constraint
3 participants