Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(remote STS): lazy fetch the secret from the vault before request #4413

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

wolf4ood
Copy link
Contributor

What this PR changes/adds

The StsRemoteClientConfiguration now holds the secret alias instead of the secret itself.

The RemoteSecureTokenService before sending the request fetches the secret from the vault with the configured secret alias.

Linked Issue(s)

Closes #4412

@wolf4ood wolf4ood requested a review from ndr-brt as a code owner August 14, 2024 10:30
@wolf4ood wolf4ood self-assigned this Aug 14, 2024
@wolf4ood wolf4ood added the enhancement New feature or request label Aug 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.96%. Comparing base (7f20ba5) to head (7639fad).
Report is 386 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4413      +/-   ##
==========================================
+ Coverage   71.74%   74.96%   +3.21%     
==========================================
  Files         919     1073     +154     
  Lines       18457    21462    +3005     
  Branches     1037     1172     +135     
==========================================
+ Hits        13242    16089    +2847     
- Misses       4756     4852      +96     
- Partials      459      521      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wolf4ood wolf4ood merged commit 8097a05 into eclipse-edc:main Aug 14, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor StsRemoteClientConfiguration
3 participants