feat: adds policy validation in policy engine #4428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolf4ood
force-pushed
the
feat/4423_policy_validation
branch
from
504b11f to
a7b9d30
Compare
jimmarino
approved these changes
Aug 22, 2024
wolf4ood
force-pushed
the
feat/4423_policy_validation
branch
2 times, most recently
from
b49f1bc to
8e3cf33
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -42,4 +43,9 @@ | |||
| */ | |||
| boolean canHandle(Object leftValue); | |||
|
|
|||
|
|
|||
| default Result<Void> validate(Object leftValue, Operator operator, Object rightValue, R rule) { | |||
Check notice
Code scanning / CodeQL
Useless parameter Note
| @@ -42,4 +43,9 @@ | |||
| */ | |||
| boolean canHandle(Object leftValue); | |||
|
|
|||
|
|
|||
| default Result<Void> validate(Object leftValue, Operator operator, Object rightValue, R rule) { | |||
Check notice
Code scanning / CodeQL
Useless parameter Note
| @@ -42,4 +43,9 @@ | |||
| */ | |||
| boolean canHandle(Object leftValue); | |||
|
|
|||
|
|
|||
| default Result<Void> validate(Object leftValue, Operator operator, Object rightValue, R rule) { | |||
Check notice
Code scanning / CodeQL
Useless parameter Note
| @@ -42,4 +43,9 @@ | |||
| */ | |||
| boolean canHandle(Object leftValue); | |||
|
|
|||
|
|
|||
| default Result<Void> validate(Object leftValue, Operator operator, Object rightValue, R rule) { | |||
Check notice
Code scanning / CodeQL
Useless parameter Note
wolf4ood
force-pushed
the
feat/4423_policy_validation
branch
from
8e3cf33 to
8c53588
Compare
wolf4ood
force-pushed
the
feat/4423_policy_validation
branch
from
8c53588 to
e09080d
Compare
ndr-brt
approved these changes
Aug 23, 2024
...olicy-engine-lib/src/main/java/org/eclipse/edc/policy/engine/validation/PolicyValidator.java
Show resolved
Hide resolved
...y-engine-lib/src/test/java/org/eclipse/edc/policy/engine/PolicyEngineImplValidationTest.java
Outdated
Show resolved
Hide resolved
...y-engine-lib/src/test/java/org/eclipse/edc/policy/engine/PolicyEngineImplValidationTest.java
Outdated
Show resolved
Hide resolved
...y-engine-lib/src/test/java/org/eclipse/edc/policy/engine/PolicyEngineImplValidationTest.java
Outdated
Show resolved
Hide resolved
...y-engine-lib/src/test/java/org/eclipse/edc/policy/engine/PolicyEngineImplValidationTest.java
Outdated
Show resolved
Hide resolved
...olicy-engine-lib/src/main/java/org/eclipse/edc/policy/engine/validation/PolicyValidator.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
adds policy validation in policy engine
Why it does that
Briefly state why the change was necessary.
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes #4423
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.