Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cleanup deprecated stuff #4451

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Sep 4, 2024

What this PR changes/adds

Remove deprecated stuff prior to 0.9.0 release

Why it does that

Briefly state why the change was necessary.

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added the refactoring Cleaning up code and dependencies label Sep 4, 2024
@ndr-brt ndr-brt requested a review from wolf4ood September 4, 2024 09:21
@ndr-brt ndr-brt force-pushed the cleanup-deprecated-stuff branch 5 times, most recently from 865ea42 to 758bda9 Compare September 4, 2024 12:18
@ndr-brt ndr-brt marked this pull request as ready for review September 4, 2024 12:18
Copy link
Contributor

@jimmarino jimmarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will approve this out of principle once you finish 🪓 ;-)

@ndr-brt ndr-brt force-pushed the cleanup-deprecated-stuff branch from 758bda9 to 10bf884 Compare September 4, 2024 12:41
@ndr-brt ndr-brt requested a review from jimmarino September 4, 2024 13:04
@ndr-brt
Copy link
Member Author

ndr-brt commented Sep 4, 2024

@jimmarino there you go :)

Copy link
Contributor

@wolf4ood wolf4ood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪓

@ndr-brt ndr-brt merged commit 04899e9 into eclipse-edc:main Sep 4, 2024
21 checks passed
@ndr-brt ndr-brt deleted the cleanup-deprecated-stuff branch September 4, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants